nodedisruption: reject instead of pending when preparing past deadline#90
Merged
Conversation
damsallem
commented
Jul 23, 2026
damsallem
commented
Contributor
- When an app was in "preparing" state and the retryable ND reach the deadline, we would never call the next step to the app since deadline is reached (setting "AnyFailed" at true).
- It was making the ND to be never deleted, because it would never reached a final state (granted or rejected).
- Here the goals is to force reject (like before the revamp of the API) if the deadline is reached.
- NB: /terminate is out of the state-machine, so it will be called at deletion of the ND, even if the deadline is reached !
* When an app was in "preparing" state and the retryable ND reach the deadline, we would never call the next step to the app since deadline is reached (setting "AnyFailed" at true). * It was making the ND to be never deleted, because it would never reached a final state (granted or rejected). * Here the goals is to force reject (like before the revamp of the API) if the deadline is reached. * NB: /terminate is out of the state-machine, so it will be called at deletion of the ND, even if the deadline is reached !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.