fix: handle invalid orgID with proper 400 error - #1245
Open
kirti763 wants to merge 1 commit into
Open
Conversation
Signed-off-by: kirti763 <kg4180553@gmail.com>
|
GHkrishna
suggested changes
Jul 11, 2025
Comment on lines
+9
to
+13
| @ApiProperty({example: '2a041d6e-d24c-4ed9-b011-1cfc371a8b8e'}) | ||
| @Transform(({ value }) => trim(value)) | ||
| @IsNotEmpty({ message: 'Please provide the valid orgID' }) | ||
| @IsString({ message: 'Organization id must be in string format.' }) | ||
| orgId?: string; | ||
| orgId: string; |
Contributor
There was a problem hiding this comment.
I think we should still try keeping the value optional as it is. Ideally this should be causing an issue.
| @@ -0,0 +1 @@ | |||
| Subproject commit ea4d5f56abc1e7aff64ab7e9d643d2fa19beac6e | |||
Contributor
There was a problem hiding this comment.
Not sure, what this file is all about. We probably might want to get rid of it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a space before an invalid
orgIdin theGET /v1/webhooks/orgs/webhookurlAPI was causing a 500 Internal Server Error.Fix
The
orgIdis now trimmed using the@Transformdecorator.Validation added using
@IsNotEmptyand@IsStringto return a 400 Bad Request iforgIdis missing or invalid.Fixes fix: Incorrect response received when providing space before invalid orgId #1220