Skip to content

fix: trim requestId in issuance controller - #1234

Open
gurparvez wants to merge 1 commit into
credebl:mainfrom
gurparvez:main
Open

fix: trim requestId in issuance controller#1234
gurparvez wants to merge 1 commit into
credebl:mainfrom
gurparvez:main

Conversation

@gurparvez

Copy link
Copy Markdown

Issue Fixed:

fix:Incorrect response received when space is added before requestId in the requestId parameter #1226

Changes

Trimmed the requestId in the controller function of the API described in the issue

@sonarqubecloud

Copy link
Copy Markdown

@GHkrishna

Copy link
Copy Markdown
Contributor

Hello @gurparvez

Thank you for the PR, closing as completed

@gurparvez

Copy link
Copy Markdown
Author

Thanks @GHkrishna
I noticed the PR is still open and has a merge conflict. Would you like me to resolve it, or are you planning to handle it on your end?

@GHkrishna

Copy link
Copy Markdown
Contributor

Ohh I actually see a PR regarding this already being merged in the reported issue. Seems like I intended to close this PR due to it.
Do you mind having a look at that once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants