feat(docker): add Dockerfile for running the test suite without local PHP (closes #674) - #772
Merged
s2x merged 4 commits intoAug 22, 2026
Conversation
added 3 commits
August 22, 2026 22:42
… PHP (closes #674) - Dockerfile on php:8.2-cli-bookworm with pcntl, posix, zip, inotify, pcov, phar.readonly=0, pcov.directory=/app/src and Composer — mirrors the most restrictive CI leg (PHP 8.2 + Symfony 6.4, PCOV coverage) - .dockerignore excludes vendor/, var/, .git, .pi-subagents/, e2e/vendor/, e2e/build/, composer.lock, tool caches - bin/docker-test helper wraps the bind-mount run with named volumes - CONTRIBUTING.md documents the Docker workflow + macOS/Linux UID caveat
- F-1: remove duplicated apt-get update in Dockerfile - F-2: add docker-entrypoint.sh that chowns named volumes (wmb-var, wmb-vendor) as root then drops to app user via runuser; fixes var/cache/dev write failure - F-3: fix --build-arg parser in bin/docker-test to accept space-separated form (--build-arg KEY=VALUE) as documented, not just --build-arg=KEY=VALUE - F-4: add memory_limit=512M to php.ini drop-in; suite needs ~150MB, php:*-cli defaults to 128M Also: update CHANGELOG entry to mention entrypoint and memory_limit, record review round 1 findings
All round 1 findings (F-1..F-4) verified as fixed. No new issues. Implementation ready for PR.
…::$trustedHosts Symfony 6.4.44+ replaced the per-host append in Request::getHost() with a single trustedHostsRegexp preg_match, so Request::$trustedHosts is never populated. Tests that asserted on its count now use the bundle's own validatedHosts cache (validatedHostsCacheCount), which is the authoritative bounded structure and exists on all supported Symfony versions.
s2x
deleted the
feat/issue-674-provide-a-dockerfile-for-running-the-tes
branch
August 22, 2026 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #674
Changes
php:8.2-cli-bookwormwithpcntl,posix,zip,inotify,pcov,phar.readonly=0,pcov.directory=/app/src,memory_limit=512Mand Composer. Mirrors the most restrictive CI leg (PHP 8.2 + Symfony 6.4, PCOV coverage).wmb-var,wmb-vendorare root-owned by default) by chowning as root, then drops to the non-rootappuser viarunuser.vendor/,var/,.git,.pi-subagents/,e2e/vendor/,e2e/build/,composer.lock, tool caches.--buildand--build-arg KEY=VALUE(both space and equals forms).-pneeded), macOS/Linux UID caveat.docker-testentry.### Addedin[Unreleased].Changelog
Added: Dockerfile + .dockerignore + docker-entrypoint.sh + bin/docker-test for running the test suite in Docker without local PHP/extensions.
Proof of Work
docs/proof_of_work/0674-dockerfile-test-suite/— 2 review rounds (round 1 found 4 findings F-1..F-4, all fixed and verified in round 2)Code Review