fix: correct Vamana/RaBitQ query params in queryVector() (closes #193) - #196
Merged
Conversation
added 2 commits
August 8, 2026 18:55
ZVecVectorQuery::setVamanaParams() and setHnswRabitqParams() both created an HnswQueryParams object, so queryVector() on Vamana/RaBitQ indexes was always rejected by the engine. Add dedicated FFI setters constructing the correct subtypes (VamanaQueryParams / HnswRabitqQueryParams), wire the PHP setters to them, and add regression tests (RaBitQ guarded for Linux x86_64).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #193
ZVecVectorQuery::setVamanaParams()andsetHnswRabitqParams()both created anHnswQueryParamsobject, soqueryVector()on Vamana/RaBitQ indexes was always rejected by the engine (query params type does not match the index type of vector field). The legacyquery()path was unaffected.Changes
ffi/zvec_ffi.cc/.h,ffi/zvec_ffi_php.h): addzvec_vector_query_set_vamana_ef_search()(VamanaQueryParams) andzvec_vector_query_set_hnsw_rabitq_ef()(HnswRabitqQueryParams), mirroringapply_query_paramssrc/ZVecVectorQuery.php): rewiresetVamanaParams()/setHnswRabitqParams()to the new FFI setters — no signature changes, BC-safetest_vector_query_vamana_params.phpt(positive + negative check),test_vector_query_rabitq_params.phpt(SKIPIF Linux x86_64, RaBitQ platform limitation)docs/helpers/faq.mdentry,CHANGELOG.mdTesting
./build_ffi.sh, symbols verified vianm)test_vector_query_object.phppassesCode Review