feat: expose random rotation for INT8/INT4 quantization (closes #177) - #186
Merged
Conversation
- Add zvec_index_params_set_quantizer_enable_rotate to FFI bridge - Wire QuantizerParam(enable_rotate) through IndexParamsHolder::build() for HNSW, Flat, IVF, and Vamana indexes (silent no-op for non-vector types, mirroring upstream C API semantics) - Add fluent ZVecIndexParams::setQuantizerEnableRotate(bool) to PHP API - Add tests/test_quantizer_enable_rotate.phpt covering HNSW/Flat/IVF/Vamana with QUANTIZE_INT8 + rotation and QUANTIZE_UNDEFINED no-op case - Update README and CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #177
Exposes zvec v0.6.0 random rotation for INT8/INT4 quantization (upstream alibaba/zvec#483) — a measured recall win on quantized indexes (e.g. Flat INT8: 0.9695 → 0.9881).
Changes
zvec_index_params_set_quantizer_enable_rotate();IndexParamsHolder::build()appliesQuantizerParam(enable_rotate)to HNSW, Flat, IVF, and Vamana params (silent no-op for non-vector types — documented divergence from upstream C API which returns INVALID_ARGUMENT)ZVecIndexParams::setQuantizerEnableRotate(bool)mirroring upstream C API / Python SDKenable_rotatenamingtests/test_quantizer_enable_rotate.phpt— HNSW/Flat/IVF/Vamana with QUANTIZE_INT8 + rotation, no-rotation default, QUANTIZE_UNDEFINED no-op caseTesting
php run-tests.php -n tests/)Code Review