test(#45): strengthen partition subdirectory test to assert prefix layout - #83
Merged
Merged
Conversation
…yout The partition subdirectory test only asserted that a child created inside a partition had the right path and existed. Nothing wrote or read an actual key through the returned subspace, so a partition prefix that silently leaked bytes outside the partition boundary would pass CI. Now the test round-trips a write through $sub->pack(['k']), asserts the child prefix strictly begins with the partition prefix, and verifies a raw getRangeAllStartsWith($partition->rawPrefix) scan surfaces that key. Changelog entry and a directory-layer doc note document the convention.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45
The partition subdirectory test only asserted that a child created inside a partition had the right path and existed — nothing wrote or read an actual key through the returned subspace, so a partition prefix that silently leaked bytes outside the partition boundary would pass CI.
Now the test:
rawPrefixstrictly begins with the partitionrawPrefix,$sub->pack(['k'])and reads it back,getRangeAllStartsWith($partition->rawPrefix)scan surfaces that exact key.(The other point raised in #45 —
getAddressesForKeyasserting onlyassertNotEmpty— was already strengthened in PR #36, so that half is already covered.)Verification
composer lint(PHPCS + Rector + PHPStan level 9): no errorscomposer test:unit: 469 tests OK--testsuite=Integrationagainst live FDB in Docker: 209 tests OK (strengthened partition test: 9 assertions OK)