Improve Codebase Evolution views and semantic diffs#50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
style-src-attrCSP directiveRoot cause
@pierre/diffsgenerates per-file grid spans as HTML style attributes. The installed VS Code webview kept those attributes visible in DevTools, but its production CSP blocked them from applying, sogrid-row: span Ncomputed toautoand every diff line occupied the same row. The--diffs-min-number-column-width-default: 2chvalue only controls gutter width and was unrelated.The fix permits style attributes only in the Codebase Evolution webview; it does not enable arbitrary inline style elements or relax script policy.
Semantic-diff qualification
Screenshots
Source changes — dark theme
Changed graph — dark theme
Semantic findings — light theme
Verification
cargo fmt --all -- --checkcargo test --workspacecargo clippy -p compass-semantic-diff --all-targets --all-features --no-deps -- -D warningsentirecomparisoncompass-vscode-0.1.1.vsixgraphify update .Known baseline
Workspace-wide Clippy still reports five pre-existing
needless_borrowfindings incompass-graph; the touched semantic-diff crate is clean with warnings denied.