fix(scroll-area): correct transition-shadows typo so the focus ring animates - #834
Open
funcpp wants to merge 1 commit into
Open
fix(scroll-area): correct transition-shadows typo so the focus ring animates#834funcpp wants to merge 1 commit into
funcpp wants to merge 1 commit into
Conversation
…nimates Tailwind's utility is singular, so `transition-shadows` compiles to nothing: the viewport gets no transition-property or duration and its focus-visible ring snaps in and out. `transition-shadow` sets `transition-property: box-shadow`, which is what `ring-2` and `ring-offset-1` render. The registry JSON and the packages/ui copy carry the same change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
@funcpp is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transition-shadowsis not a Tailwind utility. The property utility is singular (transition-shadow), so the class compiles to nothing: theScrollAreaviewport ends up with notransition-propertyortransition-duration, and thefocus-visible:ring-2 focus-visible:ring-offset-1box-shadow snaps in and out instead of easing. It is the only occurrence of the misspelling in the repo.Validation:
tailwindcss@4.1.17:.transition-shadow { transition-property: box-shadow; … }is emitted,.transition-shadowsproduces no rule at all.biome check apps/ui/registry/default/ui/scroll-area.tsxis clean.apps/ui/public/r/scroll-area.jsonandpackages/ui/src/components/scroll-area.tsxcarry the same one-character change, so the JSON content stays byte-identical to the registry source and the package copy still differs only by thecnimport rewrite.