fix: treat score 0 as a successful scan exit - #740
Open
l46983284-cpu wants to merge 2 commits into
Open
Conversation
Score 0 already produces "Passed with a score of 0 points" but the CLI treated it as failure (exit 2). Exit non-zero only for negative scores. Closes controlplaneio#580 Signed-off-by: Alex Chen <l46983284@gmail.com>
After treating score 0 as exit success, titles that still said "fails …" while calling assert_zero_points were misleading. Signed-off-by: Alex Chen <l46983284@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #580
A scan that scores exactly 0 already prints
Passed with a score of 0 points, but the CLI still exited with the failure code (2by default). That made score 0 look like a pass in the message and a fail in shell/CIautomation.Maintainer direction on the issue: treat score 0 as a pass with exit 0.
Changes
Score < 0), not<= 0assert_zero_pointswith success for score 0assert_zero_pointsso they no longer say “fails …” after the exit-code flipTest plan
go test ./pkg/ruler/ -count=1