cgroup: fix redundant NULL check in maybe_make_cgroup_threaded - #2204
Open
kolyshkin wants to merge 1 commit into
Open
cgroup: fix redundant NULL check in maybe_make_cgroup_threaded#2204kolyshkin wants to merge 1 commit into
kolyshkin wants to merge 1 commit into
Conversation
The consume_slashes() macro dereferences its argument, so checking path for NULL afterwards is too late (and flagged by CodeQL as a redundant null check due to previous dereference). Move the NULL check before consume_slashes(), keeping the empty string check after it (needed for inputs like "///"). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
fix-redundant-null-check
branch
from
August 25, 2026 07:27
dc37127 to
40bd427
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
consume_slashes()macro dereferences its argument (while (*_s == '/')), so checkingpathforNULLafter calling it is too late — a NULLpathwould crash before the check ever runs.Move the NULL check before
consume_slashes(), keeping the empty-string check after it (still needed for inputs like"///").Fixes the CodeQL alert https://github.com/containers/crun/security/code-scanning/16 (
cpp/redundant-null-check-simple).🤖 Generated with Claude Code