fix: Knative v1.22.1 e2e — pin kind to Kubernetes 1.34, drop stale v1.15.0 - #39
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause of constructive-planning#1630: Knative v1.22+ refuses to start on Kubernetes < 1.34 — its webhook/controller exit with
and crash-loop. CI's
setup-kindaction pinned kind 0.26.0 with no--image, so the cluster booted kind's default node image (k8s 1.32.0). The webhook never became ready →applyAll'swaitForServiceReadytimed out / admission webhook connection refused — exactly the "CI-only, doesn't reproduce by hand" failure (local kind was newer). Nothing was wrong with the manifests or the client apply path.Fix:
.github/actions/setup-kind: kind 0.30.0, kubectl v1.34.1, and an explicit digest-pinned--image kindest/node:v1.34.0— the cluster's Kubernetes version is part of what the suites test, so it must not float with the kind binary's default.packages/manifests:knative-servingnow carries only v1.22.1 (what downstream actually deploys); the stale v1.15.0 copy and its generated manifests are removed.packages/cliente2e: drop thePINNED_VERSIONS['knative-serving'] = 'v1.15.0'pin; the test now installs the sole available version, v1.22.1.Verified locally: reproduced the crash-loop on a k8s 1.32.0 kind cluster, then the full SetupClient e2e (cert-manager v1.17.0 + knative-serving v1.22.1, including the previously failing Knative custom resources) passes on kind 0.30.0 / kindest/node:v1.34.0.
With one version carried, the versionless-lookup ambiguity that PR #38 guards against no longer exists.
Link to Devin session: https://app.devin.ai/sessions/3e154aa102ba4137a7be595ae61140eb
Requested by: @pyramation