Skip to content

fix: Knative v1.22.1 e2e — pin kind to Kubernetes 1.34, drop stale v1.15.0 - #39

Merged
pyramation merged 1 commit into
mainfrom
fix/knative-v1221-min-k8s
Aug 13, 2026
Merged

fix: Knative v1.22.1 e2e — pin kind to Kubernetes 1.34, drop stale v1.15.0#39
pyramation merged 1 commit into
mainfrom
fix/knative-v1221-min-k8s

Conversation

@pyramation

Copy link
Copy Markdown
Collaborator

Summary

Root cause of constructive-planning#1630: Knative v1.22+ refuses to start on Kubernetes < 1.34 — its webhook/controller exit with

Version check failed
kubernetes version "1.32.0" is not compatible, need at least "1.34.0-0"

and crash-loop. CI's setup-kind action pinned kind 0.26.0 with no --image, so the cluster booted kind's default node image (k8s 1.32.0). The webhook never became ready → applyAll's waitForServiceReady timed out / admission webhook connection refused — exactly the "CI-only, doesn't reproduce by hand" failure (local kind was newer). Nothing was wrong with the manifests or the client apply path.

Fix:

  • .github/actions/setup-kind: kind 0.30.0, kubectl v1.34.1, and an explicit digest-pinned --image kindest/node:v1.34.0 — the cluster's Kubernetes version is part of what the suites test, so it must not float with the kind binary's default.
  • packages/manifests: knative-serving now carries only v1.22.1 (what downstream actually deploys); the stale v1.15.0 copy and its generated manifests are removed.
  • packages/client e2e: drop the PINNED_VERSIONS['knative-serving'] = 'v1.15.0' pin; the test now installs the sole available version, v1.22.1.
  • Workflows using kubectl v1.31.3 bumped to v1.34.1.

Verified locally: reproduced the crash-loop on a k8s 1.32.0 kind cluster, then the full SetupClient e2e (cert-manager v1.17.0 + knative-serving v1.22.1, including the previously failing Knative custom resources) passes on kind 0.30.0 / kindest/node:v1.34.0.

With one version carried, the versionless-lookup ambiguity that PR #38 guards against no longer exists.

Link to Devin session: https://app.devin.ai/sessions/3e154aa102ba4137a7be595ae61140eb
Requested by: @pyramation

@pyramation pyramation self-assigned this Aug 13, 2026
@devin-ai-integration

Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@pyramation
pyramation merged commit 008b145 into main Aug 13, 2026
14 checks passed
@pyramation
pyramation deleted the fix/knative-v1221-min-k8s branch August 13, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant