Add GitHub PR and Vista WASIp2 Resource providers - #415
Conversation
|
@codex review Posted on behalf of @schickling
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bb66b0293
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .map_or_else( | ||
| || Utc::now().to_rfc3339_opts(SecondsFormat::Secs, true), | ||
| |prior| prior.observed_at.clone(), |
There was a problem hiding this comment.
After a supervisor/process restart, SnapshotCache is empty even though the observation request still carries the persisted prior digest. An unchanged PR is therefore fetched without a prior, this branch generates a new observedAt, and the component computes a different snapshot digest and publishes all initial topics. Thus every restart can rewrite an unchanged snapshot and spuriously wake bindings; omit this volatile field from the carrier/digest or persist enough source state to compare against the prior snapshot.
Useful? React with 👍 / 👎.
agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597
agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597
agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597
6bb66b0 to
65b8614
Compare
|
@codex review Posted on behalf of @schickling
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65b861439d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fn begin(&self, context: CapabilityContext<'_>) -> Self::Invocation { | ||
| let prior_digest = match context.phase() { | ||
| CapabilityPhase::Describe => None, | ||
| CapabilityPhase::Observe(request) => { | ||
| request.prior_digest.as_ref().map(|digest| *digest.as_bytes()) | ||
| } | ||
| }; |
There was a problem hiding this comment.
When a catalog-selected component calls the GitHub import from its describe export, this invocation maps CapabilityPhase::Describe to a missing prior digest but does not retain or enforce the phase, so GitHubPrInvocation::get still performs live DNS and HTTP requests before any binding is activated. Preserve the phase and return Denied from operational imports during description; VistaModule::begin has the same omission and can spawn its configured command from describe.
Useful? React with 👍 / 👎.
1 participant
Problem
The universal WASIp2 Resource executor supports GitHub Issue and PTY Stats, but downstream catalogs also observe GitHub pull requests and Vista artifacts. Those profiles cannot migrate away from the removed host
runtime { argv ... }form without equivalent closed capabilities and components.Goal
Provide read-only GitHub PR and Vista providers through the canonical
st2:resource-provider/provider@0.1.0ABI, with exact capability scope, bounded effects, cancellation, deadlines, and stable snapshot contracts.Decisions
artifact getcommand. Do not add a compatibility fallback.Verification
Focused Cargo tests cover provider semantics, scope denial before effects, cancellation/deadlines, process-group cleanup, exact prior-digest cache binding, pagination rejection, and catalog grammar.
The Nix
wasip2-resource-providersandwasip2-resource-executorchecks are the final local package gates. A broad flake run reached 664 passing library tests but hit two existing parallel Codex app-server fixture races; both failing tests pass in isolation.Complexity
The new capability modules are required trust boundaries. Each component can import only its declared read-only host capability.
Concerns
The Vista provider requires a Vista CLI that implements
vista artifact get <slug> v<version> --output json. Downstream integration must prove that exact command before enabling the profile.Friction & bottlenecks
The broad Nix gate repeatedly exposed existing parallel filesystem/socket fixture races. Focused provider gates avoid treating those unrelated failures as provider regressions.
Follow-ups
References
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimetooling_profile