merge: restore resource profile ABI v3 history - #407
Merged
Conversation
agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597
agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597
agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597
agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597
agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597
…392) * refactor(resource): extract runtime protocol crate agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597 * feat(resource): make resync DING subjects actionable agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597 * feat(resource): publish semantic invalidation facts agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597 * test(resource): assert structured invalidations agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597 * test(resource): assert semantic resync messages agent-identity: dev3.direct.omp.2cshu64q agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.9 agent-runtime: OMP 18.0.9 tooling-profile: dotfiles@b607597
schickling-assistant
marked this pull request as ready for review
August 31, 2026 21:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainwas replaced byc2f3facca88e6cbd3c5f1024b0849c20cd66336f, whose parent is the stale9bcda7894b476b230f06686dc92c6bb321135dd4. That preserved the retired-root/root-count fix but dropped formermainat9d766557dd89a4d964339e69e8b1da0ecdd7440e, including descriptor ABI v3. ABI v3 profile modules were consequently rejected as though ABI v2 were current.Goal
Make
maindescend from both histories: retain retired-root topology semantics fromc2f3facand restore ABI v3, runtime facts, semantic invalidations, and the other former-main changes from9d76655.Decisions
main.Verification
nix develop -c cargo test -p agent-spec --features wasm-resolver --test profile_wasm— 25 passed, includingvalid_v3_descriptor_executes_and_resolve_only_module_stays_passive.nix develop -c cargo test --test validate --test catalog_graph— 58 passed, including retired-root root-slot and topology cases.nix develop -c cargo test --features wasm-resolver --test resource_profile_supervisor_e2e --test resync— 6 passed.nix develop -c cargo test -p st2-resource-protocol— 9 passed.c2f3facca88e6cbd3c5f1024b0849c20cd66336fand9d766557dd89a4d964339e69e8b1da0ecdd7440e.Complexity
No new abstraction; this reconciles two already-reviewed histories and their tests.
Concerns
PR #404 overlaps the Resource Profile files and will need to rebase on the restored history.
Friction & bottlenecks
One transient Nix source-cache lookup failed and succeeded on retry; no persistent bottleneck observed.
Follow-ups
References
9d766557dd89a4d964339e69e8b1da0ecdd7440ec2f3facca88e6cbd3c5f1024b0849c20cd66336fPosted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimetooling_profile