Admit codex-cli 0.151.0 - #394
Merged
schickling-assistant merged 1 commit intoAug 30, 2026
Merged
Conversation
agent-identity: dev3.direct.omp.jmg9x29x agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.11 agent-runtime: OMP 18.0.11 tooling-profile: dotfiles@2161b9c
schickling-assistant
marked this pull request as ready for review
August 30, 2026 20:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
st2's fail-closed native Codex driver rejects the installed
codex-cli 0.151.0before app-server initialization because the exact protocol allowlist stops at 0.147.0.Goal
Admit exactly
codex-cli 0.151.0after source and live-wire verification, while keeping later versions rejected until independently proven.Decisions
ThreadItemnote from 18 to 19 variants.clientIdfrom typedthread/resumehistory. The liveitem/completednotification did not independently advance the persisted receipt before restart.Verification
cargo test -p st2 --lib codex_app_server::tests::protocol_version_gate_accepts_only_the_exact_allowlist -- --exact: 1 passed.cargo test -p st2 --lib codex_app_server::tests::codex_context_recomputes_the_captured_reading_and_pins_its_verified_version -- --exact: 1 passed.codex --version:codex-cli 0.151.0.controlInitialized; a fresh thread bound; st2 submitted a nativeturn/start; Codex completed the turn; a deliberate driver restart reachedtuiThreadLoaded/threadBound, subscribed viathread/resume, found the matching typed-historyclientId, and persisted delivery phaseaccepted. The account had quota and both model turns completed.Complexity
No new abstraction or dependency; this is an exact admission plus evidence/test/documentation updates.
Concerns
The live
item/completednotification did not independently move the receipt fromattemptedbefore restart. Durablethread/resumereconciliation did move it toaccepted, so the proven receipt path is restart-backed rather than notification-backed.PR #386 overlaps this file and proposes replacing the exact gate with generated schema checks. This PR intentionally retains the current fail-closed exact admission policy; merge order will require an explicit policy choice.
Friction & bottlenecks
The default Codex app-server control path is a symlink in this environment, while Codex requires the path itself to be a directory. The live proof used the already-resolved account home; no repository workaround was added. No measurable bottleneck was encountered.
Follow-ups
item/completednotification did not independently advance the receipt; this does not block the proven durable resume-reconciliation path.References
Refs #267
Related: #386
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimetooling_profile