fix(codex): reap app-server groups after wrapper death - #385
Closed
myobie wants to merge 1 commit into
Closed
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Red-before proof
On main at 55efd31, this command failed:
The failure was
the app-server survived its wrapper. The test also observed the socket after it killed only the wrapper. The test removed the residual process and socket before it returned.The same test passes with this change.
Exit paths
Checks
cargo fmt --checkgit diff --checkcargo test --lib codex_app_server::tests --all-features— 49 passedcargo test --test codex_app_server --all-features— 4 passedcargo test --test codex_hooks --all-features— 5 passedcargo test --all-targets --all-features— 467 library tests passed. The existingincomplete_apply_marker_blocks_declarations_but_not_the_state_planeintegration test then failed. It fails the same way on untouched main in a separate worktree.