fix(codex): identify live socket holders - #332
Closed
myobie wants to merge 2 commits into
Closed
Conversation
Contributor
|
Superseded by the broader Codex app-server ownership work in #386. Any unique diagnostics should be folded there rather than maintaining a competing process-ownership model. Posted on behalf of @schickling
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
managed-holder.Why
The old refusal named only the socket path. An operator could not select a safe recovery action from that error.
This change adds diagnostics only. It does not clean up a process or change supervisor retry behavior. Issue #260 tracks the separate cleanup defect.
Closes #331.
Proof
The red commit is
49e02b2. It proves that the old error hides the holder facts.cargo test --lib -- --test-threads=1(456 passed; one subprocess helper ignored)cargo test --test codex_app_server(4 passed)cargo test --test targeted_reconcile(3 passed)rustfmt --edition 2024 --check src/codex_app_server.rsgit diff d4ba08c..HEAD --checkThe Linux peer test proves that kernel credentials return the listener PID. The macOS path uses
LOCAL_PEERPIDand the existingproc_pidinfointerface.