feat(stream): implement declared event ingress - #300
Conversation
2fa21f1 to
29dec2f
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2fa21f1221
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 493bc5cb70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Refreshing hosted checks after the doc-only waiter-contract commit; candidate bytes remain at 493bc5c. |
493bc5c to
0c7a94f
Compare
|
Refreshing mergeability and exact-head checks after the reviewed semantic rebase onto #287. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c7a94ffa0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
474e6c0 to
47c4aed
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47c4aed618
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
47c4aed to
15c63a9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15c63a9c48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
15c63a9 to
6e06b55
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e06b55100
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
389eeb8 to
ffdb83c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ffdb83c954
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ffdb83c to
96852d2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96852d2baa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
96852d2 to
f21f486
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2840c80fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b2840c8 to
b44cfcd
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b44cfcd085
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e650090a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6138aa8a1b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let spec = found | ||
| .specs | ||
| .iter() | ||
| .find(|spec| spec.path == target.declaration) |
There was a problem hiding this comment.
When one KDL file contains multiple agents and a launched stream is removed from an agent other than the first spec for that path, this lookup selects the wrong agent. It can consequently skip retirement or retire another agent's same-named runtime, after which edit_stream_declaration removes the correct target declaration and leaves its adapter alive and unmanaged. Fresh evidence after the earlier adapter-retirement fix is this path-only reselection; match the target identity and host as well as its declaration path.
Useful? React with 👍 / 👎.
…s unsupported (#309) archive_validated_file hardlinks the validated predecessor through /proc/self/fd/N (Linux) or /dev/fd/N (elsewhere) with AT_SYMLINK_FOLLOW. Linux procfs permits materializing that link; macOS fdescfs answers with EPERM, so publication failed on every Darwin host and cargo test -p st2 --lib could not pass there since #300. Classify EPERM/ENOSYS/EOPNOTSUPP from the capability linkat as platform-unsupported and install the receipt as a staged, fsynced, rename_noreplace byte copy instead; every other error stays a hard failure. The caller's readback proves whichever receipt won carries the validated bytes, so supersession semantics are unchanged. The tradeoff is inode identity: a crash between copy and conditional unlink leaves the retained inbox entry in place until revalidation. A debug-only TEST_FORCE_ARCHIVE_RECEIPT_COPY switch exercises the fallback on every platform; the new ding supersession test asserts receipt bytes match and no staging files leak into the archive. Fixes #308
…d human output The chosen $E surface from #268: an appended observedState object on both roster JSON shapes (null = no record, distinct from derived unknown), a compact observed column in human output, and advisory-only doctor lines. The session-liveness cross-check demands positive evidence of death (ding::session_liveness); an unreadable registry downgrades nothing. Row 22's wording now names the third independent axis with its proof, and two stale stream proof references from the #300/#313 renames are corrected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d human output The chosen $E surface from #268: an appended observedState object on both roster JSON shapes (null = no record, distinct from derived unknown), a compact observed column in human output, and advisory-only doctor lines. The session-liveness cross-check demands positive evidence of death (ding::session_liveness); an unreadable registry downgrades nothing. Row 22's wording now names the third independent axis with its proof, and two stale stream proof references from the #300/#313 renames are corrected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d human output The chosen $E surface from #268: an appended observedState object on both roster JSON shapes (null = no record, distinct from derived unknown), a compact observed column in human output, and advisory-only doctor lines. The session-liveness cross-check demands positive evidence of death (ding::session_liveness); an unreadable registry downgrades nothing. Row 22's wording now names the third independent axis with its proof, and two stale stream proof references from the #300/#313 renames are corrected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d human output The chosen $E surface from #268: an appended observedState object on both roster JSON shapes (null = no record, distinct from derived unknown), a compact observed column in human output, and advisory-only doctor lines. The session-liveness cross-check demands positive evidence of death (ding::session_liveness); an unreadable registry downgrades nothing. Row 22's wording now names the third independent axis with its proof, and two stale stream proof references from the #300/#313 renames are corrected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d human output The chosen $E surface from #268: an appended observedState object on both roster JSON shapes (null = no record, distinct from derived unknown), a compact observed column in human output, and advisory-only doctor lines. The session-liveness cross-check demands positive evidence of death (ding::session_liveness); an unreadable registry downgrades nothing. Row 22's wording now names the third independent axis with its proof, and two stale stream proof references from the #300/#313 renames are corrected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d human output The chosen $E surface from #268: an appended observedState object on both roster JSON shapes (null = no record, distinct from derived unknown), a compact observed column in human output, and advisory-only doctor lines. The session-liveness cross-check demands positive evidence of death (ding::session_liveness); an unreadable registry downgrades nothing. Row 22's wording now names the third independent axis with its proof, and two stale stream proof references from the #300/#313 renames are corrected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d human output The chosen $E surface from #268: an appended observedState object on both roster JSON shapes (null = no record, distinct from derived unknown), a compact observed column in human output, and advisory-only doctor lines. The session-liveness cross-check demands positive evidence of death (ding::session_liveness); an unreadable registry downgrades nothing. Row 22's wording now names the third independent axis with its proof, and two stale stream proof references from the #300/#313 renames are corrected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d human output The chosen $E surface from #268: an appended observedState object on both roster JSON shapes (null = no record, distinct from derived unknown), a compact observed column in human output, and advisory-only doctor lines. The session-liveness cross-check demands positive evidence of death (ding::session_liveness); an unreadable registry downgrades nothing. Row 22's wording now names the third independent axis with its proof, and two stale stream proof references from the #300/#313 renames are corrected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d human output The chosen $E surface from #268: an appended observedState object on both roster JSON shapes (null = no record, distinct from derived unknown), a compact observed column in human output, and advisory-only doctor lines. The session-liveness cross-check demands positive evidence of death (ding::session_liveness); an unreadable registry downgrades nothing. Row 22's wording now names the third independent axis with its proof, and two stale stream proof references from the #300/#313 renames are corrected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d human output (#322) * feat(agents): join observed harness state into the roster, doctor, and human output The chosen $E surface from #268: an appended observedState object on both roster JSON shapes (null = no record, distinct from derived unknown), a compact observed column in human output, and advisory-only doctor lines. The session-liveness cross-check demands positive evidence of death (ding::session_liveness); an unreadable registry downgrades nothing. Row 22's wording now names the third independent axis with its proof, and two stale stream proof references from the #300/#313 renames are corrected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(agents): catalog-derived probe root, explicit nulls, and labeled observed output Review-pass fixes for the exposure slice: the session-liveness probe derives the runner's own pty root from the catalog (PTY_ROOT and PTY_SESSION_DIR still win) so operator shells get the cross-check without exporting anything, with the errno mapping now unit-tested; observedState serializes exit and reason as explicit null per the roster's null-not-omit convention; Doctor gains the ended-while-desired-running crashed-seat advisory and tests covering all four observed-state arms; and the human observed column is prefixed obs: so two bare state words never sit ambiguously side by side. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(agents): probe exactly the runner's pty root and expose the ask kind PTY_SESSION_DIR pointed the probe at a directory st2-managed sessions never use (provable deaths read indeterminate); the probe now shares run::effective_pty_root verbatim. observedState gains the machine-readable ask axis, pinned literals updated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(agents): observedState field order matches the documented contract reason precedes exit, as the spec example pins; pinned literals updated in the same change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(agents): doctor reports a reason-only terminal instead of exit unstated An ended record can carry only a reason — Codex's observed systemError writes reason without an exit — and the catch-all advisory discarded it, leaving the operator 'exit unstated' with nothing to act on. The advisory now falls back to the recorded reason when no exit is present. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> agent-identity: unknown agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.0.3 agent-runtime: OMP 18.0.3 tooling-profile: dotfiles@f33cd9c-dirty --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: schickling-assistant <261620128+schickling-assistant@users.noreply.github.com>
1 participant
Summary
Implements the stream subsystem specified by #287 as its dependent implementation PR.
streamdeclarations with command, argv, or external ingressst2 stream add/rmauthoringst2 event emitingress with keyed and keyless supersessionVerification
PASS:
nix flake check --print-build-logs(all 9 x86_64-linux checks)Canonical failure-capable E2E proof is in compoundingtech/evals#79, exact-pinned to
29dec2f3c9dc0f9eb980f913e9c972c3f10785f1; its stream cell passes 8/8 and complete corpus preflight passes.Stack
The branch base preserves the dependency. GitHub stack metadata was removed after it repeatedly reported a false conflict for a direct-descendant head.
Originally managed with GitHub Stacks CLI