Skip to content

Distinguish unknown Codex thread statuses - #276

Draft
myobie wants to merge 1 commit into
mainfrom
agent/issue-264-unknown-status
Draft

Distinguish unknown Codex thread statuses#276
myobie wants to merge 1 commit into
mainfrom
agent/issue-264-unknown-status

Conversation

@myobie

@myobie myobie commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Add CodexHoldReason::UnknownStatus.
  • Map unrecognized Codex thread status words to that hold.
  • Preserve that hold across turn/completed.
  • Add a regression test that proves the hold stays distinct and blocks delivery.

Why

The trailing observe_thread_status arm mapped every future status word to SystemError. That mapping reported a system error that Codex did not send.

Impact

Operators can distinguish a real systemError from an unrecognized provider status. The unknown status remains a safe delivery hold.

Validation

  • cargo test -p st2 --lib codex_app_server::tests -- --nocapture: 39 passed.
  • git diff --check: passed.
  • cargo fmt --all -- --check: blocked by existing repository-wide formatting drift outside this change.

Addresses the unknown-status defect described in #264.

@myobie
myobie force-pushed the agent/issue-264-unknown-status branch from 86cb211 to 706390a Compare August 18, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant