feat: add atomic machine attach v2 - #156
Conversation
|
Nathan reviewed this direction and accepts the product boundary. Please proceed. The accepted boundary is:
Before merge, please add or link a short rollout and debugging note. It must tell an operator to record PTY_ROOT=<original-pty-root> \
~/.local/share/pty/legacy/<old-commit>/bin/pty attach <session-id>The package is currently private and is not published to the npm registry, so Recommended rollout: preserve the old checkout on each host, install the new build, restart one low-value session, test local and remote attach/detach/resize/reconnect, and then restart other sessions only when safe. Keep the old client until no old daemon remains. This comment approves the direction. It does not authorize a production rollout or automatic session restarts. |
|
I’m taking the requested independent evidence/docs pass on the accepted boundary, without rewriting or policing this shared branch. I’ll work from exact head |
|
Scope correction from Nathan: Johannes owns PR #156 and may proceed with the accepted machine-attach-v2 direction. I will not add work, change this branch, create a successor, deploy, or restart sessions. My preceding note is superseded; I’ll provide read-only support only if Johannes asks. The earlier accepted-boundary comment remains the rollout/debug contract. |
|
We will not merge this PR. The current PTY protocol remains the baseline. Fractal will first return to one current-protocol path. The long-term embedded terminal work moves to pty-rust. We will preserve this PR as design and test evidence. Useful behavior cases will move to the shared corpus in compoundingtech/pty-rust#4. Closing this PR as superseded. This does not change or restart any PTY session. |
Summary
machine-attach-v2boundary with atomic same-socket admissionVerification
tsc -p tsconfig.json --noEmittsc -p tsconfig.build.jsonDraft while the Fractal consumer is exercised against the pinned build. Architecture discussion: #155.