Stabilize inherited PTY integration tests - #149
Merged
Conversation
myobie
marked this pull request as ready for review
July 31, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
PR #128's hosted Vitest gate exposed two inherited test races. The screenshot test waited for text written before alternate-screen entry, so it could snapshot during the deliberate 300 ms alternate-screen interval. The nesting tests signaled two detached daemons directly without awaiting their exit, allowing them to recreate state while the suite removed its temporary root.
Production behavior is unchanged; this PR modifies tests only.
Validation
npm run typechecknpm run buildnpm run verify-docs(13/13)Incomplete terminfo entry), while both corrected cases pass