Skip to content

Stabilize inherited PTY integration tests - #149

Merged
myobie merged 2 commits into
mainfrom
agent/main-ci-race-fixes
Jul 31, 2026
Merged

Stabilize inherited PTY integration tests#149
myobie merged 2 commits into
mainfrom
agent/main-ci-race-fixes

Conversation

@myobie

@myobie myobie commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • wait for an explicit marker emitted after alternate-screen exit before asserting that the main buffer was restored
  • register both CLI-spawned nesting-test daemons with the existing awaited teardown barrier

Why

PR #128's hosted Vitest gate exposed two inherited test races. The screenshot test waited for text written before alternate-screen entry, so it could snapshot during the deliberate 300 ms alternate-screen interval. The nesting tests signaled two detached daemons directly without awaiting their exit, allowing them to recreate state while the suite removed its temporary root.

Production behavior is unchanged; this PR modifies tests only.

Validation

  • alternate-screen focused case: 20/20 repeated passes
  • nesting suite: 20/20 repeated passes
  • npm run typecheck
  • npm run build
  • npm run verify-docs (13/13)
  • combined screenshot + nesting files: 45/47 locally; only the two known host Nano failures (Incomplete terminfo entry), while both corrected cases pass

@myobie
myobie marked this pull request as ready for review July 31, 2026 18:59
@myobie
myobie merged commit 6345859 into main Jul 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant