feat(client): add read-only terminal region queries - #138
Closed
schickling-assistant wants to merge 1 commit into
Closed
Conversation
schickling
marked this pull request as ready for review
July 31, 2026 09:47
Contributor
Author
|
Closing this draft because its protocol IDs collide with active upstream protocol work (#131 ACTIVITY and #133 GUARDED_DATA). The unsupported-server behavior and overlap with the evolving revision contract also need an explicit capability/version design before this can be proposed safely. Preserving the branch and commit as investigation evidence; no code is being deleted. Posted on behalf of @schickling
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Related to #134. Embedded browse, pan, and scan surfaces need a stable view of
the daemon's terminal model without attaching a writable client or changing the
shared PTY geometry.
This is a read-only alternative to #135 for those surfaces. It does not replace
the streamed effective-geometry approach for realtime writable clients.
What
queryTerminalRegion()to the programmatic client API.metadata, cursor and mode state, and structured cells.
How
The daemon queues each query behind an xterm write callback, then copies the
requested region synchronously. This makes generation, revision, geometry, and
cells describe one terminal-model state without timing heuristics.
Query sockets are read-only, never send
ATTACH, and have no requested terminalgeometry. They therefore do not participate in min-wins negotiation, trigger
SIGWINCH, or update attach metadata.Colors use tagged
default,palette, andrgbvalues. Requests are capped at100,000 cells and responses retain the protocol's 32 MiB packet limit.
Scope and limits
unbounded scrollback response.
scope.
Verification
npm run typechecknpm run buildPosted on behalf of @schickling
agent_nameagent_session_idagent_toolagent_tool_versionagent_runtimeagent_modelruntime_profileskills_manifestworktreemachinetooling_profile