eval: prove stable agent identity and presentation metadata - #70
Conversation
agent-session-id: dev3.cos-fr-relay agent-tool: Codex agent-tool-version: 0.145.0 agent-model: gpt-5.6-sol agent-runtime-profile: /nix/store/qlk5xbdfmj5nn1q145j0fx73f2pmdjj7-coding-agent-runtime-profile/share/coding-agents/profile.json agent-skills-manifest: /nix/store/2km8dbiyv3wc484l1hd8n2lh65121qvq-agent-skills-corpus/share/agent-skills/manifest.json tooling-profile: dotfiles@unknown-dirty
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cac84f781
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Hold at exact head
Please return PR70 to draft if appropriate. Before marking it ready again, restack/re-pin against the accepted dependency artifacts, address the proof gaps, and record a complete model-free corpus green against the published merged st2/PTY result. |
agent-session-id: dev3.cos-fr-relay agent-tool: Codex agent-tool-version: 0.145.0 agent-model: gpt-5.6-sol agent-runtime-profile: /nix/store/qlk5xbdfmj5nn1q145j0fx73f2pmdjj7-coding-agent-runtime-profile/share/coding-agents/profile.json agent-skills-manifest: /nix/store/2km8dbiyv3wc484l1hd8n2lh65121qvq-agent-skills-corpus/share/agent-skills/manifest.json tooling-profile: dotfiles@unknown-dirty
|
Acknowledged. PR #70 is back in draft. The four acceptance-proof gaps are fixed at exact evals head The checked-in portable pin remains |
|
HOLD at exact head The new commit closes the four previously identified eval proof gaps, and the body now pins the current st2 #136 head
Please keep PR70 draft until both product owners return exact verdicts, the accepted dependencies merge and publish, this PR is repinned to those immutable artifacts, and |
|
The HOLD is retained as a merge gate, with one deliberate state distinction: per the current maintainer direction, PR #70 remains ready for review, not merge-ready. The body now states the exact boundary:
No code or proof claim changed in this pass. The conversation HOLD remains visible and there are no unresolved inline threads. |
Problem
The stable-identity change spans schema, routing, authoring, PTY projection, lifecycle reconciliation, and durable agent state. Unit coverage in st2 cannot by itself prove that those layers compose without restarting an agent or making presentation an automation alias.
Goal
Provide model-free acceptance evidence for compoundingtech/st2#136: stable
identity, optional non-uniquename, optional enduringdescription, exact-ID-only behavior, and presentation updates that preserve the live process and durable state.Decisions
summaryfield.restarted, notlaunched.0fed14buntil an immutable post-merge release exists. No prerelease tag, fake asset metadata, compatibility branch, or weakened preflight is introduced.Review and merge state
This PR is ready for review, so reviewers can assess the eval contract and the four repaired acceptance-proof gaps on the exact head below. Ready-for-review does not mean merge-ready.
Merge remains blocked until all of the following are true:
bin/check-corpus.shcompletes green against the published result.Current dependency state:
0deb3f0ad6eb07f30ad9dea6392b843d4495ad5f79b0e483d1a2f324386ac57498ca45d78157f4c7Verification
Candidate under test:
b9226b9d8cb5be958f4d8a7d948b798746f9fa1c79b0e483d1a2f324386ac57498ca45d78157f4c70deb3f0ad6eb07f30ad9dea6392b843d4495ad5fst2 0.1.0+79b0e48fceaa76a1f77948c52a411de3c2b5d6c70c4f1298890c19516f54e5a24751514agent-presentation-contractagent-presentation-continuitygit diff --checkThe strengthened contract now also proves
rename --clearreceipts/source preservation, the complete invalid-description format matrix, transitive supervisor-ancestor authorization, and that descriptions cannot route messages.The candidate-backed corpus passed through the VRS mutation gates, then stopped at the dev4 environment's configured Git signing program, which is unavailable there (
/usr/local/bin/op-ssh-sign). The guard was not bypassed, so this is not claimed as a complete corpus green. Preflight closed-set mutations, overnight policy, current-tree PII, reachable-history PII, generated catalog, and diff checks passed independently after that boundary.Complexity
The PR adds two self-contained cells and reuses the existing eval harness. It introduces no production dependency or compatibility layer.
Concerns
Both product dependencies are ready for review but remain unmerged. The checked-in corpus still validates the published portable st2 source
0fed14b. This PR is reviewable now but cannot merge until the gates in Review and merge state are satisfied.Friction & bottlenecks
The dev4 Git signing configuration prevents the synthetic commit fixture from completing because its configured signing program is absent. The proof records that boundary explicitly and does not weaken or bypass it.
Follow-ups
After PTY #142 and st2 #136 are accepted and merged and
release-portablepublishes immutable assets:SHA256SUMShashes;bin/check-corpus.shfrom its published-pin preflight through completion.References
Refs compoundingtech/st2#128.
Refs compoundingtech/st2#136.
Depends on compoundingtech/pty#142.
Supersedes #66.