chore(actions)(deps): bump actions/upload-artifact from 4 to 7 - #260
Open
dependabot[bot] wants to merge 1 commit into
Open
chore(actions)(deps): bump actions/upload-artifact from 4 to 7#260dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Dev1822
pushed a commit
that referenced
this pull request
Aug 16, 2026
…tion PIN (closes #1010)
Several controllers fetched a tenant-owned document by the raw `_id` from the
URL or request body and acted on it without checking that it belongs to the
caller's company. Where that happened, the ObjectId was the only thing
separating one customer's data from another's.
grievance.controller.js:97 Grievance.findById(req.params.id)
appraisal.controller.js:73,100 AppraisalReview.findById(req.params.id)
appraisal.controller.js:81,109 AppraisalGoal.findByIdAndUpdate(rating.goalId)
shiftRoster.controller.js:155 ShiftSwapRequest.findById(req.params.id)
shiftRoster.controller.js:161 ShiftRoster.findById(request.originalRosterId)
flashcard.controller.js:187 FlashcardDeck.findById(id)
All now go through `tenantFilter(req, { _id })`, which puts the tenant in the
query — so the row is unfetchable rather than fetched and then discarded — and
throws a 403 rather than degrading to `{}` when a request has no tenant.
The appraisal goal updates are the ones to look at first. Those ids come from
the request body, not from the review, so they were as untrusted as the `:id`
— and that path *writes*. Unscoped, a caller could rewrite the achievement
figures on any goal in the database, in any company, without ever touching a
review they were entitled to. They are now scoped to the tenant, the cycle and
the employee.
The checks that did exist were worse than absent
------------------------------------------------
`taxProof.verifyProof` and `employee.toggleActive` both had a tenant check:
if (proof.tenantId.toString() !== req.tenantId)
`auth.middleware` sets `req.tenantId` from `user.tenantId`, a mongoose
ObjectId. A string primitive is never strictly equal to an object, so that
expression is *always true* and both endpoints answered 404/403 to everybody,
the owning tenant included. HR could not approve a tax proof, and nobody could
deactivate an employee — which is what removes them from payroll (#260).
They failed closed by luck. Written as `if (a.toString() === b) { allow }` the
identical mistake fails open, so `sameTenant()` is added to `tenantScope.js`
for the few places that genuinely cannot scope the query — a document reached
indirectly inside a transaction — and coerces both sides with String().
POSH decryption
---------------
`decryptCase` fetched `iccMember` and never read it, so a caller who was not on
the committee at all decrypted anyway; and `pin` was read from the body and
never compared to anything, the comparison living in a comment reading "in a
real app, compare against decryptionPinHash using bcrypt". The second factor
the endpoint advertises did not exist.
It is enforced now, with bcrypt against `decryptionPinHash`, and a refused
attempt emits `POSH_CASE_DECRYPT_DENIED` — an audit trail that records only
successes cannot show somebody guessing at PINs against one case.
`requireICC` on the route was already correct and is untouched. It proves the
caller is on their own tenant's committee; what it cannot do is constrain which
case id they then name.
Deliberately not included
-------------------------
The `createdBy` ownership checks in `updateEmployee`/`deleteEmployee` are left
as they are. They are not tenant checks and are arguably too strict for a
shared HR workspace, but relaxing them widens who may modify employee records
— a permission-model decision, not a security fix, and it should not ride
along in this PR. #1010 records the reasoning.
Also fixed while scoping `approveSwap`: `originalRoster` was dereferenced on
the next line without a null check, so a swap request pointing at a deleted
roster row crashed with a TypeError inside an open transaction.
Tests: 21 new cross-tenant cases asserting the tenant is in the query and that
a foreign id 404s without writing, plus 9 for `sameTenant`. Three existing
suites had mocks pinned to `findById`; those move to `findOne`. One test
simulated a cross-tenant employee by mutating the returned document, which only
worked because the old code compared after fetching — rewritten so the scoped
query returns nothing, which is what actually happens now.
A handful of unused imports (`mongoose`, `logger`, `CaseNote`, `deleteDeck`)
are removed from the touched files. lint-staged only lints staged files, so
they had never been reported; they block the commit hook now.
Full backend suite: no new failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/upload-artifact from 4 to 7.
Release notes
Sourced from actions/upload-artifact's releases.
... (truncated)
Commits
043fb46Merge pull request #797 from actions/yacaovsnc/update-dependency634250cInclude changes in typespec/ts-http-runtime 0.3.5e454baaReadme: bump all the example versions to v7 (#796)74fad66Update the readme with direct upload details (#795)bbbca2dSupport direct file uploads (#764)589182cUpgrade the module to ESM and bump dependencies (#762)47309c9Merge pull request #754 from actions/Link-/add-proxy-integration-tests02a8460Add proxy integration testb7c566aMerge pull request #745 from actions/upload-artifact-v6-releasee516bc8docs: correct description of Node.js 24 support in READMEDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)