Skip to content

Let you specify a parent element - #20

Open
aullman wants to merge 6 commits into
coderaiser:masterfrom
aullman:master
Open

Let you specify a parent element#20
aullman wants to merge 6 commits into
coderaiser:masterfrom
aullman:master

Conversation

@aullman

@aullman aullman commented Oct 28, 2019

Copy link
Copy Markdown

I wanted to be able to create a dialog in a separate window which meant I had to pass in a different document.body element to be the parent element.

It's probably a good idea to write a test for this scenario but I wasn't sure how to. If you point me in the right direction I'm happy to have a go at it though.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 92.391% when pulling 7478ceb on aullman:master into a009d84 on coderaiser:master.

@coveralls

coveralls commented Oct 28, 2019

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-1.009%) to 91.383% when pulling 88aabec on aullman:master into a009d84 on coderaiser:master.

It was complaining and wanting to use shorthand properties. But I think that it's more descriptive as is and so disabling that rule.
@coderaiser

Copy link
Copy Markdown
Owner

Please reinstall dependencies, and run fix again. Things like:

const TAB = 9;	
const event = {
    keyCode: TAB,
}

Should stay :).

@aullman

aullman commented Dec 6, 2019

Copy link
Copy Markdown
Author

Sorry, just saw this. I reverted the unnecessary changes. Hopefully the tests pass this time.

@coderaiser

coderaiser commented Mar 7, 2020

Copy link
Copy Markdown
Owner

Would be great if you add test for this :) and squash it to one commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants