Skip to content

Add download retries #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeconscious merged 5 commits into from
Aug 10, 2026
Merged

Add download retries #89

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44a570d
Initial test version
codeconscious Jul 10, 2026
0773612
Add more logging
codeconscious Jul 11, 2026
6c73ba5
Update error message
codeconscious Jul 18, 2026
e7fe4b3
Fix attempt counting
codeconscious Jul 20, 2026
8151abc
Refactor downloadMedia [AI]
codeconscious Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 50 additions & 36 deletions src/CCVTAC.Main/Downloading/Downloader.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ open CCVTAC.Main.IoUtilities.Directories
open CCVTAC.Main.Downloading.Downloading
open CCVTAC.Main.ExternalTools
open CCVTAC.Main.Settings.Settings
open CCFSharpUtils
open CCFSharpUtils.Text
open FsToolkit.ErrorHandling
open System

Expand Down Expand Up @@ -69,43 +71,55 @@ module Downloader =
let downloadMedia (printer: Printer) (mediaType: MediaType) userSettings (PrimaryUrl url)
: Result<string list, string list> =

// One attempt refers to a set of attempted downloads for all audio formats.
let maximumAttempts = 3

if not mediaType.IsVideo && not mediaType.IsPlaylistVideo then
printer.Info("Please wait for multiple videos to be downloaded...")

let rec loop errors audioFormats =
match audioFormats with
| [] ->
Error errors
| format :: formats ->
let args = generateDownloadArgs (Some format) userSettings (Some mediaType) (Some [url])
let commandWithArgs = $"{programName} {args}"
let downloadSettings = ToolSettings.create commandWithArgs userSettings.WorkingDirectory

let downloadResult = runTool downloadSettings [1] printer
let filesDownloaded = audioFileCount userSettings.WorkingDirectory Files.audioFileExts > 0

match downloadResult, filesDownloaded with
| Ok result, true ->
Ok <|
$"Successfully downloaded the \"{format}\" format."
:: match result.Error with
| Some err -> [$"However, a minor issue was reported: {err}"]
| None -> []
| Ok result, false ->
Error <|
$"The \"{format}\" format download was reported as successful, but no audio files were downloaded!"
:: match result.Error with
| Some err -> [err]
| None -> []
| Error err, true ->
Error <|
[$"The downloader reported failure for \"{format}\", yet audio files were unexpectedly downloaded!"
err]
| Error err, false ->
let newErr = $"A download error was reported for the \"{format}\" format, and no audio files were downloaded. {err}"
loop (List.append errors [newErr]) formats

loop [] userSettings.AudioFormats
printer.Info "Please wait for multiple videos to be downloaded..."

let buildErrorMessage mainMsg maybeErr =
match maybeErr with
| Some err -> [mainMsg; err]
| None -> [mainMsg]

let attemptAudioFormat format errors =
let args = generateDownloadArgs (Some format) userSettings (Some mediaType) (Some [url])
let commandWithArgs = $"{programName} {args}"
let downloadSettings = ToolSettings.create commandWithArgs userSettings.WorkingDirectory

let downloadResult = runTool downloadSettings [1] printer
let anyFilesDownloaded = Num.isPos <| audioFileCount userSettings.WorkingDirectory Files.audioFileExts

match downloadResult, anyFilesDownloaded with
| Ok result, true ->
Ok (
$"Successfully downloaded the \"{format}\" format."
:: match result.Error with Some err -> [$"However, a minor issue was reported: {err}"] | None -> []
)
| Ok result, false ->
let msg = $"While the downloader finished successfully, no audio files were downloaded in the \"{format}\" format."
Error (errors @ buildErrorMessage msg result.Error)
| Error err, true ->
let msg = $"The downloader reported failure for \"{format}\", yet audio files were unexpectedly downloaded!"
Error (errors @ buildErrorMessage msg (Some err))
| Error err, false ->
let msg = $"A download error was reported for the \"{format}\" format, and no audio files were downloaded. {err}"
Error (errors @ [msg])

let rec retryLoop errors attemptsRemaining audioFormats =
if Num.isZero attemptsRemaining then
Error (errors @ [$"Gave up after {maximumAttempts} failed attempts."])
else
match audioFormats with
| [] ->
// All formats attempted, retry with full list
retryLoop errors (attemptsRemaining - 1) userSettings.AudioFormats
| format :: remainingFormats ->
match attemptAudioFormat format errors with
| Ok msgs -> Ok msgs
| Error errs -> retryLoop errs attemptsRemaining remainingFormats

retryLoop [] maximumAttempts userSettings.AudioFormats

let downloadMetadata (printer: Printer) userSettings (SupplementaryUrl url) : Result<string, string list> =
match url with
Expand Down