refactor: inline address formatting in EventCalendar to remove layer violation#2710
Merged
Merged
Conversation
…violation EventCalendar (infrastructure layer) was using AddressPresenter (presentation layer) to format venue addresses. Inline the simple join of address fields directly, matching AddressPresenter#to_s behaviour without the upward dependency.
KimberleyCook
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Services::EventCalendarinlib/services/(infrastructure layer) depends onAddressPresenterinapp/presenters/(presentation layer). This breaks the layered architecture rule that lower layers must not depend on higher layers.Solution
Inline the address formatting directly in the service. The
AddressPresenter#to_smethod does a simple join of[flat, street, city, postal_code]— no presenter needed.Verification
EventInvitationMailer#attending, which still passes the same event objectLayer analysis context
This was identified by a full layered-architecture audit of the codebase. The audit found no other critical layer violations.