fix: inline EventHelper concern into Event model#2705
Open
mroderick wants to merge 1 commit into
Open
Conversation
EventHelper was a single-model concern (only used by Event). Inline its validation methods directly into Event and remove the concern file to eliminate unnecessary indirection. This follows the precedent set by inlining Permissions into Member.
KimberleyCook
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Inline the
EventHelperconcern into theEventmodel.EventHelperwas only included byEvent, making it a code-slicing (single-model) concern.Why
Single-model concerns add indirection without sharing. The same pattern was previously applied to
Permissions(inlined intoMember). Keeping validation logic directly in the model is simpler and more discoverable.Changes
app/models/concerns/event_helper.rbintoapp/models/event.rb(private section, alongside existingduplicated_sponsors)include EventHelperfrom Eventapp/models/concerns/event_helper.rbTesting
spec/models/event_spec.rb— 34 examples, 0 failures