fix: use HEROKU_RELEASE_VERSION for static asset cache-busting#49
Merged
Conversation
HEROKU_SLUG_COMMIT requires runtime-dyno-metadata but was undocumented. Switch to HEROKU_RELEASE_VERSION and document the lab feature requirement.
mroderick
marked this pull request as ready for review
July 19, 2026 12:46
till
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #48 introduced
HEROKU_SLUG_COMMITfor cache-busting static assets. This env var requires theruntime-dyno-metadatalab feature, which was not enabled or documented. The version always falls back todev.Solution
Switch to
HEROKU_RELEASE_VERSION(also provided byruntime-dyno-metadata) and document the lab feature requirement in the Heroku setup docs.I deployed this branch to Heroku (
codebar-auth-production), to confirm that it works.Changes
src/app/components/layout.js— simplifiedSTATIC_VERSIONtoHEROKU_RELEASE_VERSION || "dev", removed unusedSOURCE_VERSIONandHEROKU_SLUG_COMMITfallbacksdocs/heroku-setup.md— addedheroku labs:enable runtime-dyno-metadatato setup steps, addedHEROKU_RELEASE_VERSIONto the environment variables tablePrerequisite
The
runtime-dyno-metadatalab must be enabled on all Heroku environments. It is already enabled on production: