[pull] main from ueberdosis:main - #184
Merged
Merged
Conversation
…7670) * fix(react): prevent crash when ReactNodeViewRenderer returns early When contentComponent is not available, return a minimal valid NodeView with a placeholder DOM element instead of an empty object. This prevents ProseMirror from crashing with 'dom.hasAttribute is not a function' when using custom atom nodes with renderHTML returning text in the initial document. Fixes #7641 * test(react): cover node view fallback * Update .changeset/fix-react-node-view-renderer.md --------- Co-authored-by: cyphercodes <cyphercodes@users.noreply.github.com> Co-authored-by: Dominik Biedebach <6538827+bdbch@users.noreply.github.com>
* fix(extension-youtube): embed YouTube live URLs `isValidYoutubeUrl` accepts `youtube.com/live/<id>`, so `setYoutubeVideo` and the paste rule insert the node, but `getEmbedUrlFromYoutubeUrl` returned null for it: the id regex only knew `v=`, `list=` and `shorts/`. The result was an iframe with no src, and the original URL was lost on the next HTML round trip. Match `live/` the same way `shorts/` is matched. `youtu.be` is handled separately just above and is unaffected. Fixes #8209 * fix(extension-youtube): anchor the shorts and live match to a path boundary The id regex searched the whole URL, so `youtube.com/notlive/<id>` and `watch?redirect=live/<id>` both produced an embed for that id. This already applied to `shorts/` before live was added. Require the alternatives to start at a path separator, and reword the changeset to user-facing terms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )