[pull] main from ueberdosis:main - #182
Merged
Merged
Conversation
…ready cached (#8188) * fix(extension-image): reveal resizable node view when the image is already cached The resize node view hides the element and clears visibility only inside el.onload. A cached image is already complete before the node view mounts, so load never fires again and the image stays permanently invisible. Reveal immediately when the image is already loaded, and on error as well so a broken src renders as an inspectable broken image rather than an invisible node. * docs: shorten the changeset to one user-facing sentence Their guidelines ask for one short sentence about visible behaviour, without internals — mine explained the root cause. The reasoning stays in the commit and the PR, where it belongs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )