Skip to content

[pull] main from react:main #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Jul 7, 2026
+47 −16
Merged

[pull] main from react:main #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 36 additions & 16 deletions compiler/crates/react_compiler_hir/src/default_module_type_provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,22 +77,42 @@ pub fn default_module_type_provider(module_name: &str) -> Option<TypeConfig> {
})),

"@tanstack/react-virtual" => Some(TypeConfig::Object(ObjectTypeConfig {
properties: Some(IndexMap::from_iter([(
"useVirtualizer".to_string(),
TypeConfig::Hook(HookTypeConfig {
positional_params: Some(Vec::new()),
rest_param: Some(Effect::Read),
return_type: Box::new(TypeConfig::TypeReference(TypeReferenceConfig {
name: BuiltInTypeRef::Any,
})),
return_value_kind: None,
no_alias: None,
aliasing: None,
known_incompatible: Some(
"TanStack Virtual's `useVirtualizer()` API returns functions that cannot be memoized safely".to_string(),
),
}),
)])),
properties: Some(IndexMap::from_iter([
(
"useVirtualizer".to_string(),
TypeConfig::Hook(HookTypeConfig {
positional_params: Some(Vec::new()),
rest_param: Some(Effect::Read),
return_type: Box::new(TypeConfig::TypeReference(TypeReferenceConfig {
name: BuiltInTypeRef::Any,
})),
return_value_kind: None,
no_alias: None,
aliasing: None,
known_incompatible: Some(
"TanStack Virtual's `useVirtualizer()` API returns functions that cannot be memoized safely".to_string(),
),
}),
),
// `useWindowVirtualizer()` wraps the same virtualizer instance as `useVirtualizer()`,
// so its return value is incompatible for the same reason.
(
"useWindowVirtualizer".to_string(),
TypeConfig::Hook(HookTypeConfig {
positional_params: Some(Vec::new()),
rest_param: Some(Effect::Read),
return_type: Box::new(TypeConfig::TypeReference(TypeReferenceConfig {
name: BuiltInTypeRef::Any,
})),
return_value_kind: None,
no_alias: None,
aliasing: None,
known_incompatible: Some(
"TanStack Virtual's `useWindowVirtualizer()` API returns functions that cannot be memoized safely".to_string(),
),
}),
),
])),
})),

_ => None,
Expand Down
11 changes: 11 additions & 0 deletions compiler/packages/babel-plugin-react-compiler/src/HIR/DefaultModuleTypeProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,17 @@ export function defaultModuleTypeProvider(
returnType: {kind: 'type', name: 'Any'},
knownIncompatible: `TanStack Virtual's \`useVirtualizer()\` API returns functions that cannot be memoized safely`,
},
/*
* `useWindowVirtualizer()` wraps the same virtualizer instance as `useVirtualizer()`, so its return value
* is incompatible for the same reason and we mark the entire hook as incompatible
*/
useWindowVirtualizer: {
kind: 'hook',
positionalParams: [],
restParam: Effect.Read,
returnType: {kind: 'type', name: 'Any'},
knownIncompatible: `TanStack Virtual's \`useWindowVirtualizer()\` API returns functions that cannot be memoized safely`,
},
},
};
}
Expand Down
Loading