[pull] main from Shopify:main - #220
Merged
Merged
Conversation
Both are declared as `(value: boolean) => void` in the TypeScript API, and
the CanvasKit backend forwards the boolean straight through. On native they
were bound with a `double` parameter, so `JSIConverter<double>` called
`asNumber()` on the argument and a real boolean threw:
Exception in HostFunction: Value is true, expected a number
Binding them as `bool` routes through `JSIConverter<bool>`, which uses
`asBool()`, matching the two neighbouring boolean setters
(`setEmbeddedBitmaps` and `setLinearMetrics`) and the declared API.
The `double` parameters date back to the typed-bindings migration (#3965),
which preserved the previous `asNumber()` behaviour so as not to change
semantics in a mechanical refactor. That kept the JS API unusable on native
without casting the argument to a number.
Co-authored-by: William Candillon <wcandillon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )