[pull] main from Shopify:main - #219
Merged
Merged
Conversation
processTransform3d built the skew matrices with React Native's MatrixMath indices, but MatrixMath is column-major while Matrix4 here is row-major. The shear factor therefore landed in the transposed slot, so `skewX` sheared vertically and `skewY` sheared horizontally - the opposite of CSS, React Native and SkMatrix, where skewX offsets x in proportion to y. This is the only path behind the `transform` prop, `processTransform2d` and the exported `processTransform3d`, so every backend was affected. The two skew baselines were recorded against the swapped behaviour and are regenerated here.
declareImageShader called makeShaderCubic on both branches, so the
non-cubic path passed a FilterMode and a MipmapMode where the cubic B
and C coefficients belong. The default became a B-spline cubic
(B = FilterMode.Linear = 1, C = MipmapMode.None = 0) instead of a plain
bilinear filter, and sampling={{ filter: FilterMode.Nearest }} silently
resampled with a cubic filter rather than nearest neighbour.
drawImage already picks between drawImageRectCubic and
drawImageRectOptions the same way, and the native recorder defaults to
SkFilterMode::kLinear, so only the JS player was affected.
Co-authored-by: William Candillon <wcandillon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )