[pull] main from Shopify:main - #217
Merged
Merged
Conversation
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.15.0 to 3.15.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/3.15.1/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.15.0...3.15.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.15.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ViewScreenshotService.drawChildren() reflected for ReactViewGroup.dispatchOverflowDraw(Canvas) to reproduce overflow clipping while walking the view tree manually. React Native removed that method in 0.77.0 and moved the clip into ReactViewGroup.dispatchDraw(), which calls BackgroundStyleApplicator.clipToPaddingBox(). Since the library's peer dependency is react-native >=0.78, the reflection fails on every supported version: it throws NoSuchMethodException once per ReactViewGroup per capture, logs a stack trace, and never applies the clip. Children of a view with overflow: hidden / scroll therefore bleed outside their parent in the image returned by makeImageFromView(). Replicate the clip with a direct call to BackgroundStyleApplicator.clipToPaddingBox(), which is public and @JvmStatic across the whole supported React Native range, so a future removal surfaces as a build error instead of a silent runtime regression. --------- Co-authored-by: William Candillon <wcandillon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )