[pull] main from Shopify:main - #203
Merged
Merged
Conversation
ViewScreenshotService clips scroll containers to their viewport while compositing the view tree, but only checks `instanceof ScrollView`. HorizontalScrollView does not extend ScrollView (both extend FrameLayout), so a horizontal scroll container was never clipped: an oversized child such as a wide Skia <Canvas> (a TextureView) inside one bled past its viewport to the output bitmap edge in the captured image. Clip HorizontalScrollView as well; getScrollX/Y/getWidth/getHeight are View methods so the existing clip math works unchanged (the ScrollView cast is dropped). iOS is unaffected. Co-authored-by: Hirvesh <hirvesh.munogee@gmail.com> Co-authored-by: William Candillon <wcandillon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )