[pull] main from Shopify:main - #201
Merged
Merged
Conversation
…oxes (#3930) Adds specs reproducing #3493: after layout, Paragraph.getHeight()/getRectsForRange()/getLineMetrics() all report heights derived from font metrics (ascent + descent), so 'Hello' and 'Typography' measure the same height, while Font.measureText returns bounds tight to the actual glyphs but has no font fallback. Also covers that Paragraph resolves CJK text through fallback fonts where the Font API returns .notdef glyphs. Also renders a paragraph using Roboto with Noto Sans SC as fallback and strokes the rect reported by getRectsForRange for each glyph, snapshotting the result as a PNG like the other paragraph test suites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )