Skip to content

[pull] canary from vercel:canary #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Aug 23, 2026
+23 −1
Merged

[pull] canary from vercel:canary #1330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...es/next/src/next-devtools/dev-overlay/components/errors/dev-tools-indicator/draggable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,12 @@ export function Draggable({
}

return (
<div {...props} {...drag} ref={ref}>
<div
{...props}
{...drag}
ref={ref}
style={{ touchAction: 'none', ...props.style }}
>
{children}
</div>
)
Expand Down
17 changes: 17 additions & 0 deletions test/development/app-dir/devtools-position/default-position.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,21 @@ describe('devtools-position-default', () => {
expect(style).toContain('bottom: 20px')
expect(style).toContain('left: 20px')
})

it('should disable browser touch gestures on the draggable indicator', async () => {
const browser = await next.browser('/')
await getDevIndicatorPosition(browser)

const touchAction = await browser.eval(() => {
const portal = Array.from(
document.querySelectorAll('nextjs-portal')
).find((p) => p.shadowRoot?.querySelector('[data-nextjs-toast]'))
const indicator = portal?.shadowRoot?.querySelector('[data-nextjs-toast]')
const draggable = indicator?.firstElementChild

return draggable ? getComputedStyle(draggable).touchAction : null
})

expect(touchAction).toBe('none')
})
})
Loading