[pull] canary from vercel:canary - #1327
Merged
Merged
Conversation
### Why? Should come up with better solution that does not block PRs with git conflict x-ref: https://vercel.slack.com/archives/C02CDC2ALJH/p1785263902728189?thread_ts=1785263687.502649&cid=C02CDC2ALJH ### How? - Delete `errors.json`, the error-code SWC plugin, generated WASM, merge driver, and validation/build tooling. - Stop attaching error codes to server-rendering digests, redboxes, and telemetry; native `Error.code` and `Error.name` remain available where applicable. - Remove the development-overlay error feedback UI, middleware, and telemetry event that depended on stable codes. - Update fixtures, snapshots, and guidance for code-free errors and numeric-only digests. <!-- NEXT_JS_LLM -->
…n a map (#97655) This is a spiritual continuation of #96114 . See #94735 for motivation. This codepath should already be pretty cheap, but in some cases (notably inotify on Linux where updates aren't debounced as aggressively by the OS) it could become somewhat hot and waste CPU while other somewhat-CPU-heavy work is happening in other software (e.g. `pnpm`). This removes two more sources of clones: - If we only have a `&Path`, but it's already in the `paths` map, we can use the raw entry API to avoid cloning it. - `new_paths` can use `usize` indexes into the `FxIndexMap` instead of storing another clone of the path. We could also encode this information as flags on `path`, but the iteration over `new_paths` must happen as a separate loop before the normal batch execution loop (near the bottom of `DiskWatcher::watch_thread`), so I'd like to keep it as a separate data structure to avoid having to filter out a bunch of unrelated keys without the flag when finally processing the batch.
…(s) (#97710) The `useSelectedLayoutSegment` and `useSelectedLayoutSegments` hooks accept a parameter named `parallelRouteKey` (singular), as declared in `packages/next/src/client/components/navigation.ts`: export function useSelectedLayoutSegment(parallelRouteKey: string = 'children') The docs wrote it as `parallelRoutesKey` (plural) in three files, which doesn't match the generated `navigation.d.ts` type that editors surface via IntelliSense: - `use-selected-layout-segment.mdx` — parameter signature and description - `use-selected-layout-segments.mdx` — parameter signature and description - `parallel-routes.mdx` — "With useSelectedLayoutSegment(s)" section Docs-only change; no behavior change. --- Credit: This contribution was originally authored by @see-stack in #97690 and is recreated here with signed commits. Co-authored-by: Said Nasser <sdnssr001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )