Conversation
This reverts commit 448b95f.
## Why The Android lifecycle listener guide explains how to implement `expo.modules.core.interfaces.Package`, but it does not explain how that class is registered. This leaves module authors unsure whether they need to edit `MainApplication` or `expo-module.config.json`. ## What changed - clarify that Expo Autolinking discovers Android source files ending in `Package.java` or `Package.kt` that implement `Package` - explain that the Android build adds them to the generated `ExpoModulesPackageList` - document that no manual `MainApplication` or package config entry is needed - add the Gradle clean/rebuild recovery step for a stale generated package list ## Test plan - `cd docs && pnpm test` — 58 suites, 620 tests passed - `cd docs && pnpm test:worker` — all worker and route checks passed - `cd docs && NODE_ENV=production pnpm lint --max-warnings 0` — passed - `cd docs && pnpm lint-prose` — 0 errors, warnings, or suggestions - `cd docs && pnpm lint` — passed Closes #28409.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )