Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
32 changes: 18 additions & 14 deletions .github/workflows/agent-commands.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
# in place instead of posting a new one (GitHub keeps the
# edit history). If the thread has no findings comment
# yet, a new one is posted. Dispatch input: `retry`.
# ... --announce post the "started — watch the run" comment. Off by
# default; the eyes reaction is the only receipt.
# ... --no-announce skip the "started — watch the run" comment; the
# eyes reaction is then the only receipt. Announcing
# is the default on the comment path (dispatch runs
# are always quiet).
# @expo-bot check verify + review from one comment. This workflow runs the
# verify half (--fix / --no-fix apply, issues and PRs);
# expo-code-review-command.yml picks up the review half
Expand Down Expand Up @@ -515,12 +517,14 @@ jobs:
;;
esac
fi
# The "started — watch the run" comment is opt-in: threads stay
# quiet unless the commander asks for the watch link with
# --announce. The eyes reaction remains the default receipt.
announce=false
if [ "$QUIET" != "true" ]; then
case " $line " in *" --announce "*) announce=true ;; esac
# The "started — watch the run" comment posts by default on the
# comment path; --no-announce opts a thread out, leaving the eyes
# reaction as the only receipt. Dispatch runs stay quiet always.
announce=true
if [ "$QUIET" = "true" ]; then
announce=false
else
case " $line " in *" --no-announce "*) announce=false ;; esac
fi
# --retry: the publish phase passes updateLatest to the findings
# tool, so the thread's previous findings comment is edited in
Expand Down Expand Up @@ -562,10 +566,10 @@ jobs:
GH_TOKEN: ${{ secrets.EXPO_BOT_GITHUB_TOKEN }}
run: gh api -X POST "repos/${{ github.repository }}/issues/comments/${{ github.event.comment.id }}/reactions" -f content=eyes

# Opt-in via --announce: the Actions run streams the agent's live
# progress, and this posts that link the moment work begins (the
# Watchable from the start: the Actions run streams the agent's live
# progress, so the thread gets that link the moment work begins (the
# findings comment lands separately when the investigation completes).
# Default is no comment — the eyes reaction is the only receipt.
# --no-announce opts out, leaving the eyes reaction as the only receipt.
- name: Announce run
if: steps.gate.outputs.ok == 'true' && steps.cmd.outputs.route == 'true' && steps.cmd.outputs.announce == 'true' && env.QUIET != 'true'
env:
Expand All @@ -588,9 +592,9 @@ jobs:
# are in_progress too, so ordering by (created_at, id) IS the queue;
# admission by global position keeps the executing count at CAP even
# when several waiters poll at once. Runs pending on the per-target
# group are not in_progress and hold no capacity. With --announce the
# thread has the watch link during this wait; by default the queue
# wait is visible only from the Actions tab.
# group are not in_progress and hold no capacity. The announce above
# already posted the watch link (unless --no-announce), so the queue
# wait is visible from the thread.
- name: Wait for a free verification slot
if: steps.gate.outputs.ok == 'true' && steps.cmd.outputs.route == 'true'
env:
Expand Down
1,825 changes: 1,825 additions & 0 deletions 0380-expo-runtime-agent-semantics.rfc.md

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion apps/router-e2e/.env
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ EXPO_NOT_PUBLIC_TEST_VALUE=not-public-value
EXPO_SKIP_MANIFEST_VALIDATION_TOKEN=0
EXPO_NO_TELEMETRY=1
TEST_SECRET_VALUE=test-secret
# EXPO_UNSTABLE_WEB_MODAL=1
EXPO_UNSTABLE_LOG_BOX=1
EXPO_DEBUG_LOG_BOX=1

Expand Down
94 changes: 0 additions & 94 deletions apps/router-e2e/__e2e__/web-modal/app/_layout.tsx

This file was deleted.

68 changes: 0 additions & 68 deletions apps/router-e2e/__e2e__/web-modal/app/index.tsx

This file was deleted.

12 changes: 0 additions & 12 deletions apps/router-e2e/__e2e__/web-modal/app/modal-fit.tsx

This file was deleted.

10 changes: 0 additions & 10 deletions apps/router-e2e/__e2e__/web-modal/app/modal-margin.tsx

This file was deleted.

14 changes: 0 additions & 14 deletions apps/router-e2e/__e2e__/web-modal/app/modal-multi.tsx

This file was deleted.

52 changes: 0 additions & 52 deletions apps/router-e2e/__e2e__/web-modal/app/modal-regular-bg.tsx

This file was deleted.

63 changes: 0 additions & 63 deletions apps/router-e2e/__e2e__/web-modal/app/modal-regular.tsx

This file was deleted.

Loading
Loading