Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
.idea
.vscode
.junie
.playwright-mcp

vite.config.ts.timestamp-*.mjs
vite.config.mts.timestamp-*.mjs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ describe('Quick Filter', () => {
validateState({ gridRows: 17, displayedRows: 0, templateRows: 0 });

// To have all the async functions run we flush our fakeAsync test environment. This empties the call stack
flush(25);
flush(40);
// So now our component has its displayedRows property updated as the grid callback has been run
// However, this has not been reflected in our template yet as change detection has not run.
validateState({ gridRows: 17, displayedRows: 17, templateRows: 0 });
Expand All @@ -114,7 +114,7 @@ describe('Quick Filter', () => {
validateState({ gridRows: 10, displayedRows: 17, templateRows: 17 });

// We now flush out all the async callbacks
flush(25);
flush(40);
// Our component event handler has now been run and updated its displayedRows value
validateState({ gridRows: 10, displayedRows: 10, templateRows: 17 });

Expand All @@ -127,7 +127,7 @@ describe('Quick Filter', () => {

it('should filter rows by quickFilterText', fakeAsync(() => {
fixture.detectChanges();
flush(25);
flush(40);
fixture.detectChanges();

validateState({ gridRows: 17, displayedRows: 17, templateRows: 17 });
Expand All @@ -136,7 +136,7 @@ describe('Quick Filter', () => {
quickFilterDE.nativeElement.dispatchEvent(new Event('input'));

fixture.detectChanges();
flush(25);
flush(40);
fixture.detectChanges();

validateState({ gridRows: 10, displayedRows: 10, templateRows: 10 });
Expand Down
10 changes: 1 addition & 9 deletions packages/ag-grid-community/src/rendering/rowRenderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -734,15 +734,7 @@ export class RowRenderer extends BeanStub implements NamedBean {
return;
}

let containerHeight = this.pageBounds.getCurrentPageHeight();
// we need at least 1 pixel for the horizontal scroll to work. so if there are now rows,
// we still want the scroll to be present, otherwise there would be no way to scroll the header
// which might be needed us user wants to access columns
// on the RHS - and if that was where the filter was that cause no rows to be presented, there
// is no way to remove the filter.
if (containerHeight === 0) {
containerHeight = 1;
}
const containerHeight = this.pageBounds.getCurrentPageHeight();

rowContainerHeight.setModelHeight(containerHeight + additionalHeight);
}
Expand Down
Loading