[pull] latest from ag-grid:latest - #897
Merged
Merged
Conversation
Homepage hero gains Free Trial and Buy Now CTAs; the Get Started For Free section CTA becomes Explore the Docs with a Try Enterprise Free CTA beside it, and Integrated Charts gains a Free Trial CTA. Adds an optional secondaryCta to LandingPageSection so a section can carry a second CTA, and shares the demo video tour link across all four demo pages, renamed to Video Tour.
* [Excel Export] - Fixed Row Outline * [Excel Export] - Fixed Column Outline * [Excel Export] - Row Outline coverage for groupHideOpenParents
…anged (#14930) The `/sitemap` page lists the pages in the sitemap, but the sitemap is only generated once every page — including that one — has been built, so production and archive builds ran `astro build` twice unconditionally to catch it up. The first build now records which sitemap its sitemap pages rendered from, and `buildWithSitemapCache` only builds again when that differs from the sitemap the build went on to generate. Since the sitemap pages render nothing but the `<loc>` list, that is the comparison made — `<lastmod>` changes on every build and never reaches either page. - Archive builds skip the second build outright: they register no sitemap integrations at all, so nothing a second build produces can differ. - `agCacheSitemap` now keys the cache on the page list rather than the git hash, which answered neither "did the page list move" question: a commit can touch no page, and a rebuild at the same commit can still change the page list. - The docs `build` nx input narrows from the whole sitemap cache folder to `sitemap-0.xml`, so the `buildDate` in the cached `meta.json` no longer forces a rebuild on every run.
…14928) * AG-3390 Fix the contact form captcha across client-side navigation Ported from ag-studio (#2446). Both contact-form files were byte-identical to studio's pre-fix copies, so they carry over verbatim. darkmodeStore dispatched a CustomEvent named `message` on `window`, and re-fired it on every `astro:after-swap`. reCAPTCHA's api.js parses `event.origin` as a URL, which a CustomEvent does not have, so it threw `Cannot read properties of undefined (reading 'match')` on every navigation. Nothing in this repo consumes the event - integrated-charts dark mode runs off a separate `document` `color-scheme-change` channel - so the dispatch is removed rather than renamed. ContactForm relied on api.js's one-shot auto-render, which never runs again after a swap replaces the container, leaving an empty box. It now loads reCAPTCHA in explicit-render mode and renders on each mount, keeping the widget id: a bare `getResponse()` reads widget 0 and throws `No reCAPTCHA clients exist.` once that widget's container is gone, so the form silently refused to submit with no error shown. initCaptcha now takes the container, so it reads the widget's own response field - reCAPTCHA suffixes every field after the first, so the bare-id lookup missed them and the timestamp never froze at solve time - and returns a `stop()` the effect calls on unmount, instead of leaking another 500ms ticker on every visit to the page. * AG-3390 Share the reCAPTCHA load state across module instances Park the in-flight promise on `window` instead of a module variable, and skip the injection entirely when a usable `grecaptcha` is already present. What the promise guards is global - the injected script tag and the `grecaptcha` it defines - so a second module instance has to join the load already under way rather than append a duplicate script. Note that a tag-presence check would not do the job: an Astro page swap removes the injected script from the head, so by the second visit there is no tag left to find even though `grecaptcha` is still loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )