fix(huawei-agc): register onAfterCompressSettings hook and fix templa… - #931
Merged
Conversation
oahcy
requested review from
qiuguohua and
tangkaikk
and removed request for
qiuguohua
September 8, 2026 12:26
…te fallback path huawei-agc inherits AndroidPackTool but its hooks.ts was missing the onAfterCompressSettings export, so nativePackToolMg.create() never ran and native/engine/huawei-agc/ (build.gradle, CMakeLists.txt) was never generated, breaking the gradle `apply from: NATIVE_DIR + "/build.gradle"`. Also fix the CMakeLists fallback copy in AndroidPackTool.create() to point at templates/android/template instead of platformTemplateDirInCocos, which resolves to the non-existent templates/huawei-agc/template for huawei-agc. Co-Authored-By: Claude Code <noreply@anthropic.com> docs(android): correct huawei-agc template reuse comment Co-Authored-By: Claude Code <noreply@anthropic.com>
Changdw
approved these changes
Sep 9, 2026
Contributor
Author
star-e
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…te fallback path
huawei-agc inherits AndroidPackTool but its hooks.ts was missing the onAfterCompressSettings export, so nativePackToolMg.create() never ran and native/engine/huawei-agc/ (build.gradle, CMakeLists.txt) was never generated, breaking the gradle
apply from: NATIVE_DIR + "/build.gradle".Also fix the CMakeLists fallback copy in AndroidPackTool.create() to point at templates/android/template instead of platformTemplateDirInCocos, which resolves to the non-existent templates/huawei-agc/template for huawei-agc.
docs(android): correct huawei-agc template reuse comment