Skip to content

Fix check-dts failure by removing .d.ts dependency on runtime interface.ts - #907

Draft
star-e with Copilot wants to merge 2 commits into
v0.0.1-alpha.40from
copilot/fix-check-dts-job-failure
Draft

Fix check-dts failure by removing .d.ts dependency on runtime interface.ts#907
star-e with Copilot wants to merge 2 commits into
v0.0.1-alpha.40from
copilot/fix-check-dts-job-failure

Conversation

Copilot AI commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

check-dts was failing because API Extractor traversed src/core/assets/@types/interface.ts from declaration files and raised ae-wrong-input-file-type, which then caused DTS generation to fail.
This change keeps the affected declaration files self-contained so API Extractor only processes declaration-safe inputs.

  • Root-cause alignment

    • Removed .d.ts imports/re-exports that referenced ./interface.ts under src/core/assets/@types.
  • Declaration-surface adjustments

    • In asset-types.d.ts, replaced derived runtime-based declarations with explicit declaration-time unions:
      • ISupportCreateType
      • AssetHandlerType
    • In userDatas.d.ts, inlined declaration enums used by types:
      • NormalImportSetting
      • TangentImportSetting
    • Removed export * from './interface' from userDatas.d.ts.
  • Representative change

    // before (.d.ts pulled runtime .ts)
    import { NormalImportSetting, TangentImportSetting } from './interface';
    export * from './interface';
    
    // after (.d.ts is self-contained)
    export declare enum NormalImportSetting { optional = 0, exclude = 1, require = 2, recalculate = 3 }
    export declare enum TangentImportSetting { exclude = 0, optional = 1, require = 2, recalculate = 3 }

Co-authored-by: star-e <13654656+star-e@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job check-dts Fix check-dts failure by removing .d.ts dependency on runtime interface.ts Sep 3, 2026
Copilot AI requested a review from star-e September 3, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants