Skip to content

feat(desktop): support native launchers cross-platform - #179

Merged
cnjack merged 1 commit into
mainfrom
codex/desktop-apps-cross-platform
Jul 30, 2026
Merged

feat(desktop): support native launchers cross-platform#179
cnjack merged 1 commit into
mainfrom
codex/desktop-apps-cross-platform

Conversation

@cnjack

@cnjack cnjack commented Jul 30, 2026

Copy link
Copy Markdown
Owner

What changed

  • Show the task context titlebar and Open in… launcher on every Tauri desktop platform; macOS keeps the overlay band while Windows and Linux render below native window chrome.
  • Add Windows discovery through the per-user/per-machine uninstall registry, validated publishers and known install paths, with native executable icon extraction and launch handling for editors, File Explorer, and terminals.
  • Add Linux discovery through freedesktop .desktop entries, TryExec, XDG application directories, and hicolor-compatible icon lookup, including selected file-manager and terminal launch behavior.
  • Keep macOS Launch Services behavior in a dedicated platform module and preserve opaque application IDs at the webview/native boundary.
  • Accept canonical Windows drive paths and common Linux mount/workspace roots while rejecting relative paths, UNC paths in the web adapter, and undeclared application IDs.
  • Show platform-appropriate panel shortcut labels and use semantic editor/file-manager/terminal fallback icons.

Why

PR #178 introduced native installed-app discovery for macOS. Windows and Linux still used the browser fallback and returned no native applications. This brings the same task context and installed-application launcher experience to all supported desktop targets while following each OS's registration model instead of guessing from a shared PATH.

Validation

  • pnpm --dir web test — 19 tests passed
  • make lint-web
  • make build-web
  • go test ./...
  • cargo test --manifest-path desktop/src-tauri/Cargo.toml — 3 macOS tests passed
  • cargo clippy --manifest-path desktop/src-tauri/Cargo.toml --all-targets -- -D warnings
  • Windows target: cargo clippy --target x86_64-pc-windows-msvc --all-targets -- -D warnings with Tauri bundle resources disabled for cross-checking
  • Linux discovery module: 4 tests passed, x86_64-unknown-linux-gnu target check passed, and Clippy passed in an isolated harness
  • git diff --check

make lint remains blocked by the existing 44 SA5011 findings in untouched Go test files. The complete Tauri Linux cross-build additionally requires a Linux GTK/GDK sysroot, which is not installed on the macOS development host; the Linux platform module itself was target-compiled and tested independently.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cnjack, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 16045a34-3121-4053-ba65-18952efaf670

📥 Commits

Reviewing files that changed from the base of the PR and between 9ee212b and 7439e4c.

⛔ Files ignored due to path filters (1)
  • desktop/src-tauri/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (12)
  • desktop/src-tauri/Cargo.toml
  • desktop/src-tauri/src/desktop_apps.rs
  • desktop/src-tauri/src/desktop_apps/linux.rs
  • desktop/src-tauri/src/desktop_apps/macos.rs
  • desktop/src-tauri/src/desktop_apps/unsupported.rs
  • desktop/src-tauri/src/desktop_apps/windows.rs
  • web/src/App.tsx
  • web/src/components/DesktopTitlebar.test.tsx
  • web/src/components/DesktopTitlebar.tsx
  • web/src/components/TopBar.tsx
  • web/src/lib/useDesktop.test.ts
  • web/src/lib/useDesktop.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cnjack
cnjack marked this pull request as ready for review July 30, 2026 17:08
@cnjack
cnjack merged commit c53e0b9 into main Jul 30, 2026
3 of 4 checks passed
@cnjack
cnjack deleted the codex/desktop-apps-cross-platform branch July 30, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant