Drop separate table files keeping only merged ones. Add tables for MF model 170812 - #5
Open
namapane wants to merge 2 commits into
Open
Drop separate table files keeping only merged ones. Add tables for MF model 170812#5namapane wants to merge 2 commits into
namapane wants to merge 2 commits into
Conversation
Contributor
Author
|
@perrotta: FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged MF interpolation files have been introduced in cms-sw/cmssw#38051, but at the time the merged files were added only for the 3.8 T working point, and without removing the separate files to avoid breaking unit tests.
With cms-sw/cmssw#51526, the mechanism to use merged files has been extended to all MF builders, so that it is now possible to stop distributing thousands of individual files and keep only the merged ones.
In this PR, the 11136 individual data files are removed for each of the 4 160812 maps (3.8 T, 3.5 T, 3 T, 3.8 T@Run I), replacing them by the merged files when not already present.
In addition, merged tables for all nominal working points (including 2 T, which was missing in 160812) for the "legacy" map version 170812 are added. Compared to 160812, this model mainly includes corrected steel magnetization curves for ss400 steel [cf. here]. The resulting difference was found to be very small, and for this reason at the time consensus was not reached to release this model.
However, I believe it is important to release these tables for the long term future of CMS because:
Notes
20_1_0_pre3when it will be released.Testing
Tested the merged tables for all 160812 models with the MF regression (checks for identical results over a large number of random points) with all MF builders ((static, from DB) x (DDD, dd4HEP))
Tested the 170812 models for the expected differences in the same regression.