Fix CVE-2024-45337: upgrade golang.org/x/crypto to v0.31.0 - #26
Open
n8behavior wants to merge 1 commit into
Open
Fix CVE-2024-45337: upgrade golang.org/x/crypto to v0.31.0#26n8behavior wants to merge 1 commit into
n8behavior wants to merge 1 commit into
Conversation
Resolves critical Dependabot alert #110: - CVE-2024-45337: Misuse of ServerConfig.PublicKeyCallback may cause authorization bypass in golang.org/x/crypto. Upgraded golang.org/x/crypto v0.0.0-20180222 -> v0.31.0. Also fixed 4 pre-existing `go vet` warnings in arguscontroller_utils.go: - Lines 166, 183, 198: replaced redundant fmt.Errorf(fmt.Sprintf(...)) with fmt.Errorf(...) - Line 258: consolidated multiple fmt.Sprintf calls in glog.V(4).Infof into a single format string Cascading dep upgrades: golang.org/x/{net,sync,sys,text,tools}. Vendor directory re-synced. Verified with `go build ./...` and `go vet ./...`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves 1 critical Dependabot security alert with a targeted dependency bump, plus fixes pre-existing
go vetwarnings.Critical alert resolved
ServerConfig.PublicKeyCallbackmay cause authorization bypass ingolang.org/x/crypto. Upgraded fromv0.0.0-20180222→v0.31.0.Cascading dependency upgrades
golang.org/x/net→v0.25.0golang.org/x/sync→v0.10.0golang.org/x/sys→v0.28.0golang.org/x/text→v0.21.0golang.org/x/tools→v0.21.1Code fixes
Fixed 4
go vetwarnings inpkg/controller/arguscontroller_utils.go:fmt.Errorf(fmt.Sprintf(...))→fmt.Errorf(...)(redundant wrapping)glog.V(4).Infof(fmt.Sprintf(...) + ...)→ single format stringVendor directory re-synced via
go mod vendor.Test plan
go build ./...passesgo vet ./...passes (0 warnings)