Skip to content

chore(deps): bump quick-cache to 0.7.0 - #2645

Merged
carneiro-cw merged 4 commits into
mainfrom
foldhash_cache
Aug 28, 2026
Merged

chore(deps): bump quick-cache to 0.7.0#2645
carneiro-cw merged 4 commits into
mainfrom
foldhash_cache

Conversation

@carneiro-cw

@carneiro-cw carneiro-cw commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

PR Type

Enhancement, Documentation


Description

  • Bump quick_cache to v0.7.0 and adapt cache API

  • Replace Cache::with with Cache::with_weighter

  • Update supply-chain/audits.toml with quick_cache audit

  • Add comment for parse_revm_state improvement


Diagram Walkthrough

flowchart LR
  A["Cargo.toml: bump quick_cache to 0.7.0"]
  B["storage/cache.rs: migrate to Cache::with_weighter API"]
  C["supply-chain/audits.toml: add quick_cache audit entry"]
  D["transaction_execution.rs: add parse_revm_state comment"]
  A --> B
  A --> C
  B --> D
Loading

File Walkthrough

Relevant files
Documentation
transaction_execution.rs
Add improvement comment in parse_revm_state                           

src/eth/executor/evm/types/output/transaction_execution.rs

  • Add comment on filtering temp and cache slots
+2/-1     
Dependency update
cache.rs
Adapt StorageCache to quick_cache v0.7 API                             

src/eth/storage/cache.rs

  • Remove FxBuildHasher and DefaultLifecycle imports
  • Change Cache generics to three parameters
  • Replace Cache::with with Cache::with_weighter
+4/-14   
Dependencies
Cargo.toml
Bump quick_cache to v0.7.0                                                             

Cargo.toml

  • Bump quick_cache version from 0.6.22 to 0.7.0
+1/-1     
Configuration changes
audits.toml
Add quick_cache supply-chain audit entry                                 

supply-chain/audits.toml

  • Add new audits.quick_cache entry for v0.7.0
  • Document audit criteria, delta, and notes
+6/-0     

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit 6ddd37c)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Fix typo in comment

Fix the typo in the comment to use "slots" instead of "stots" for clarity and to
prevent confusion.

src/eth/executor/evm/types/output/transaction_execution.rs [275]

-// and discard stots found in temp and cache
+// and discard slots found in temp and cache
Suggestion importance[1-10]: 1

__

Why: This is a trivial comment typo fix with no impact on functionality.

Low

carneiro-cw added a commit that referenced this pull request Aug 28, 2026
carneiro-cw added a commit that referenced this pull request Aug 28, 2026
@carneiro-cw
carneiro-cw force-pushed the foldhash_cache branch 2 times, most recently from 97553d1 to 6ddd37c Compare August 28, 2026 15:12
@carneiro-cw carneiro-cw changed the title Foldhash cache chore(deps): bump quick-cache to 0.7.0 Aug 28, 2026
@carneiro-cw
carneiro-cw marked this pull request as ready for review August 28, 2026 15:13
@carneiro-cw
carneiro-cw requested a review from a team as a code owner August 28, 2026 15:13

@cloudwalk-review-agent cloudwalk-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Dependency bump to quick_cache 0.7.0 is consistently applied (Cargo.toml + lockfile), and cache construction was migrated to Cache::with_weighter with matching generic updates in StorageCache. The supply-chain audit entry for quick_cache was added with an explicit reviewed delta (0.6.22 -> 0.7.0).

I did not find concrete correctness, security, concurrency, or deploy-safety regressions in the provided diff.

@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 6ddd37c

@github-actions

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@cloudwalk-review-agent cloudwalk-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Dependency bump to quick_cache 0.7.0 is consistently applied (Cargo.toml + Cargo.lock), and the cache construction was correctly migrated from Cache::with(...) to Cache::with_weighter(...) with matching type updates in StorageCache.

I did not find concrete correctness, concurrency, security, or deploy-safety regressions in the provided diff. The supply-chain audit entry for quick_cache (0.6.22 -> 0.7.0) is present and aligned with the dependency update.

@carneiro-cw
carneiro-cw dismissed cloudwalk-review-agent[bot]’s stale review August 28, 2026 15:54

The merge-base changed after approval.

carneiro-cw added a commit that referenced this pull request Aug 28, 2026

@cloudwalk-review-agent cloudwalk-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Dependency bump to quick_cache 0.7.0 is consistently applied (Cargo.toml + Cargo.lock), and the cache API migration in src/eth/storage/cache.rs is coherent with the new crate signature (Cache::with_weighter and updated generic arity).

I did not find concrete regressions in correctness, concurrency behavior, security posture, or deploy safety in the provided diff. The supply-chain audit entry for quick_cache (0.6.22 -> 0.7.0) is present and aligned with the dependency update.

gventino-cw
gventino-cw previously approved these changes Aug 28, 2026

@cloudwalk-review-agent cloudwalk-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Dependency bump to quick_cache 0.7.0 is consistently applied (Cargo.toml + Cargo.lock), and the cache API migration in src/eth/storage/cache.rs is coherent with the new signature (Cache::with_weighter and 3-parameter Cache<...> usage).

I did not find concrete regressions in correctness, concurrency behavior, security posture, deploy safety, or API contracts in the provided diff. The supply-chain audit entry for quick_cache (0.6.22 -> 0.7.0) is present and aligned with the dependency update.

f3l1ph3s
f3l1ph3s previously approved these changes Aug 28, 2026
@carneiro-cw
carneiro-cw dismissed stale reviews from f3l1ph3s, cloudwalk-review-agent[bot], and gventino-cw August 28, 2026 19:54

The merge-base changed after approval.

@cloudwalk-review-agent cloudwalk-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Dependency bump to quick_cache 0.7.0 is consistently applied (Cargo.toml + Cargo.lock), and the cache API migration in src/eth/storage/cache.rs is coherent with the new signature (Cache::with_weighter and 3-parameter Cache<...> usage).

I did not find concrete regressions in correctness, concurrency behavior, security posture, deploy safety, or API contracts in the provided diff. The supply-chain audit entry for quick_cache (0.6.22 -> 0.7.0) is present and aligned with the dependency update.

Base automatically changed from improve_state to main August 28, 2026 20:24

@cloudwalk-review-agent cloudwalk-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Dependency bump to quick_cache 0.7.0 is consistently applied (Cargo.toml + Cargo.lock), and the API migration in src/eth/storage/cache.rs is coherent with the new Cache::with_weighter / 3-parameter Cache<...> usage.

I did not find concrete regressions in correctness, concurrency behavior, security posture, deploy safety, or API contracts in the provided diff. The new cargo-vet audit entry for quick_cache (0.6.22 -> 0.7.0) is present and aligned with the dependency update.

@carneiro-cw
carneiro-cw merged commit b670919 into main Aug 28, 2026
51 checks passed
@carneiro-cw
carneiro-cw deleted the foldhash_cache branch August 28, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants