chore(deps): bump quick-cache to 0.7.0 - #2645
Conversation
PR Reviewer Guide 🔍(Review updated until commit 6ddd37c)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
97553d1 to
6ddd37c
Compare
There was a problem hiding this comment.
Summary
Dependency bump to quick_cache 0.7.0 is consistently applied (Cargo.toml + lockfile), and cache construction was migrated to Cache::with_weighter with matching generic updates in StorageCache. The supply-chain audit entry for quick_cache was added with an explicit reviewed delta (0.6.22 -> 0.7.0).
I did not find concrete correctness, security, concurrency, or deploy-safety regressions in the provided diff.
|
Persistent review updated to latest commit 6ddd37c |
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Summary
Dependency bump to quick_cache 0.7.0 is consistently applied (Cargo.toml + Cargo.lock), and the cache construction was correctly migrated from Cache::with(...) to Cache::with_weighter(...) with matching type updates in StorageCache.
I did not find concrete correctness, concurrency, security, or deploy-safety regressions in the provided diff. The supply-chain audit entry for quick_cache (0.6.22 -> 0.7.0) is present and aligned with the dependency update.
The merge-base changed after approval.
f99a892 to
3383afd
Compare
There was a problem hiding this comment.
Summary
Dependency bump to quick_cache 0.7.0 is consistently applied (Cargo.toml + Cargo.lock), and the cache API migration in src/eth/storage/cache.rs is coherent with the new crate signature (Cache::with_weighter and updated generic arity).
I did not find concrete regressions in correctness, concurrency behavior, security posture, or deploy safety in the provided diff. The supply-chain audit entry for quick_cache (0.6.22 -> 0.7.0) is present and aligned with the dependency update.
3383afd to
bcb0822
Compare
There was a problem hiding this comment.
Summary
Dependency bump to quick_cache 0.7.0 is consistently applied (Cargo.toml + Cargo.lock), and the cache API migration in src/eth/storage/cache.rs is coherent with the new signature (Cache::with_weighter and 3-parameter Cache<...> usage).
I did not find concrete regressions in correctness, concurrency behavior, security posture, deploy safety, or API contracts in the provided diff. The supply-chain audit entry for quick_cache (0.6.22 -> 0.7.0) is present and aligned with the dependency update.
The merge-base changed after approval.
bcb0822 to
f92fa90
Compare
There was a problem hiding this comment.
Summary
Dependency bump to quick_cache 0.7.0 is consistently applied (Cargo.toml + Cargo.lock), and the cache API migration in src/eth/storage/cache.rs is coherent with the new signature (Cache::with_weighter and 3-parameter Cache<...> usage).
I did not find concrete regressions in correctness, concurrency behavior, security posture, deploy safety, or API contracts in the provided diff. The supply-chain audit entry for quick_cache (0.6.22 -> 0.7.0) is present and aligned with the dependency update.
f92fa90 to
26dcf57
Compare
There was a problem hiding this comment.
Summary
Dependency bump to quick_cache 0.7.0 is consistently applied (Cargo.toml + Cargo.lock), and the API migration in src/eth/storage/cache.rs is coherent with the new Cache::with_weighter / 3-parameter Cache<...> usage.
I did not find concrete regressions in correctness, concurrency behavior, security posture, deploy safety, or API contracts in the provided diff. The new cargo-vet audit entry for quick_cache (0.6.22 -> 0.7.0) is present and aligned with the dependency update.
PR Type
Enhancement, Documentation
Description
Bump
quick_cacheto v0.7.0 and adapt cache APIReplace
Cache::withwithCache::with_weighterUpdate
supply-chain/audits.tomlwith quick_cache auditAdd comment for
parse_revm_stateimprovementDiagram Walkthrough
File Walkthrough
transaction_execution.rs
Add improvement comment in parse_revm_statesrc/eth/executor/evm/types/output/transaction_execution.rs
cache.rs
Adapt StorageCache to quick_cache v0.7 APIsrc/eth/storage/cache.rs
FxBuildHasherandDefaultLifecycleimportsCachegenerics to three parametersCache::withwithCache::with_weighterCargo.toml
Bump quick_cache to v0.7.0Cargo.toml
quick_cacheversion from 0.6.22 to 0.7.0audits.toml
Add quick_cache supply-chain audit entrysupply-chain/audits.toml
audits.quick_cacheentry for v0.7.0