Locket retry interval should use 5s instead of 1s to be less aggressive - #498
Open
dsboulder wants to merge 1 commit into
Open
Locket retry interval should use 5s instead of 1s to be less aggressive#498dsboulder wants to merge 1 commit into
dsboulder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very fast retries can cause a DoS in locket as existing requests pile up and must be processed 1-at-a-time before new requests are executed (due to SELECT FOR UPDATE holding the row lock)
Summary
My environment is slow enough where I occasionally see a locket request take longer than 1s. Components with a 1s retry will give up on the request because it take to long and then immediately make another request for ~15 retries. None of them succeed because they pile up on each other at the locket server.